Verify and improve restarting behavior in certain case #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
okurz
approved these changes
Apr 27, 2023
kalikiana
reviewed
Apr 28, 2023
* Add test for the problematic restart handling we have seen recently on o3 (see https://progress.opensuse.org/issues/128267) * Add test case to check whether restarting the 2nd root in a dependency tree like the one from that issue works as well (after the first root has already been restarted) * Ensure the cluster has been stopped before enqueuing a Minion job that possibly restarts it as it would otherwise mark the scheduled jobs in that cluster as `parallel_failed` * This test fails without 29bcb6c which is actually the main fix (although it intends to improve a slightly different situation)
Martchus
force-pushed
the
debug-strange-restart
branch
from
82c195a
to
741ff73
Compare
mimi1vx
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o3 (see https://progress.opensuse.org/issues/128267)
dependency tree like the one from that issue works as well (after
the first root has already been restarted)
possibly restarts it as it would otherwise mark the scheduled jobs in
that cluster as
parallel_failedis actually the main fix (although it intends to improve a slightly
different situation)