Avoid race condition when reading step details #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code currently checks whether the file is readable and shows an error to the user if not. This check is not atomic so we might still run into e.g. `Can't open file ".../libssh-18.txt": No such file or directory at OpenQA/Schema/Result/JobModules.pm line 113` leading to a server-side error and a 500 response. With this change we always show the error to the user. This commit also changes another occurrence of the same lookup-pattern to be consistent (although it is probably not strictly required there). Related ticket: https://progress.opensuse.org/issues/159447
kalikiana
approved these changes
Apr 23, 2024
okurz
approved these changes
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5588 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 392 392
Lines 38266 38266
=======================================
Hits 37656 37656
Misses 610 610 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code currently checks whether the file is readable and shows an error to the user if not. This check is not atomic so we might still run into e.g.
Can't open file ".../libssh-18.txt": No such file or directory at OpenQA/Schema/Result/JobModules.pm line 113leading to a server-side error and a 500 response. With this change we always show the error to the user.This commit also changes another occurrence of the same lookup-pattern to be consistent (although it is probably not strictly required there).
Related ticket: https://progress.opensuse.org/issues/159447