Fix products being wrongly re-scheduled with the setting AMP;ASYNC=1
#5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After f20a0bf job settings specified as query parameters are handled also when the `scheduled_product_clone_id` parameter is present. This revealed the problem that we don't correctly pass the `async=1` parameter on the products log page. This change fixes the problem by removing the too excessive escaping. This also fixes the problem that the async-flag was not actually passed. This is now tested in the UI test (which would fail without this change). Related ticket: https://progress.opensuse.org/issues/162608
Martchus
force-pushed
the
scheduling-button
branch
from
2343de3
to
8d5f3f9
Compare
Martchus
changed the title
AMP;ASYNC=1AMP;ASYNC=1
baierjan
approved these changes
Jun 20, 2024
perlpunk
approved these changes
Jun 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5715 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 394 394
Lines 38503 38515 +12
=======================================
+ Hits 37895 37907 +12
Misses 608 608 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After f20a0bf job settings specified as query parameters are handled also when the
scheduled_product_clone_idparameter is present. This revealed the problem that we don't correctly pass theasync=1parameter on the products log page. This change fixes the problem by removing the too excessive escaping.This also fixes the problem that the async-flag was not actually passed. This is now tested in the UI test (which would fail without this change).
Related ticket: https://progress.opensuse.org/issues/162608