Auto reload result page on state change from scheduled to running #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdil12
changed the title
coolo
requested changes
Oct 12, 2016
| else if (state == "scheduled") { | ||
| // reload when test starts | ||
| window.setInterval(function() { | ||
| $.ajax("/tests/" + jobid + "/status").done(function(newStatus) { |
There was a problem hiding this comment.
don't hard code URLs in javascript - I thought I told you yesterday
asdil12
force-pushed
the
sched_auto_refresh
branch
from
264eb99
to
a428e17
Compare
|
Good approach |
coolo
reviewed
Oct 12, 2016
| window.setInterval(function() { | ||
| $.ajax(status_url).done(function(newStatus) { | ||
| if (newStatus.state == 'running' || newStatus.state == 'waiting') { | ||
| setTimeout(function() {location.href = location.href.replace(/#.*/, '');}, 1000); |
There was a problem hiding this comment.
I wonder if we shouldn't just reload if the status changed. If the job goes from scheduled to obsoleted, you want to know too.
asdil12
force-pushed
the
sched_auto_refresh
branch
from
a428e17
to
e62aed9
Compare
coolo
approved these changes
Oct 12, 2016
|
Now of course I wonder if this can't be tested. |
|
it's not obvious how, but as this is not a critical feature put some thought into it |
asdil12
force-pushed
the
sched_auto_refresh
branch
from
e62aed9
to
28e17b5
Compare
|
Rebased. |
|
The complete js code on the running page is not tested because phantomJS doesn't like our websocket stuff. Also I don't see a way of updating the db that is used by the phantomJS mojo instance while the mojo instance is running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/2238