Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugrefs in textres #949

Merged
merged 2 commits into from
Oct 20, 2016
Merged

Bugrefs in textres #949

merged 2 commits into from
Oct 20, 2016

Conversation

Martchus
Copy link
Contributor

Implement https://progress.opensuse.org/issues/14310#change-30138

The test does not work yet, see out commented lines.

@okurz
Copy link
Member

okurz commented Oct 19, 2016

LGTM

@Martchus
Copy link
Contributor Author

Actually I want to find out why my test doesn't work. PhantomJS thinks that the elements I want to access are not attached to the DOM tree. However, make_screenshot shows that the elements are displayed on the page.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.295% when pulling 037fd48 on Martchus:bugrefs_in_textres into 91993f8 on os-autoinst:master.

@Martchus Martchus changed the title WIP: Bugrefs in textres Bugrefs in textres Oct 20, 2016
@Martchus
Copy link
Contributor Author

Test should work now, too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.295% when pulling 84a0e4c on Martchus:bugrefs_in_textres into 91993f8 on os-autoinst:master.

aaannz
aaannz approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaannz aaannz merged commit 4e2ae48 into os-autoinst:master Oct 20, 2016
@Martchus Martchus deleted the bugrefs_in_textres branch October 20, 2016 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaannz aaannz aaannz approved these changes

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Martchus @okurz @coveralls @aaannz