Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Remove "heartbeat" ignore which we would like to see again"" #36

Closed
wants to merge 1 commit into from

Conversation

kalikiana
Copy link
Member

@kalikiana
Copy link
Member Author

On a side note, the message of the PR I'm reverting is terrible. Imho it should've said Reinstate heartbeat ignore rules. But I learned we follow existing practice so I'm doing the same.

@Martchus
Copy link
Contributor

Martchus commented May 9, 2022

We have tracked the cause of the issue. However, unless I'm missing something we haven't actually fixed the issue. Shouldn't we at least resolve https://progress.opensuse.org/issues/110680 and possibly also https://progress.opensuse.org/issues/110677 before reinstating the alert for this log message?

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, the message of the PR I'm reverting is terrible. Imho it should've said Reinstate heartbeat ignore rules. But I learned we follow existing practice so I'm doing the same.

Sounds a bit passive aggressive. Certainly we shouldn't eventually end up with "Revert Revert Revert Revert …". I am sure you can do better than this. But also see the comment by Martchus. I don't think we should merge that yet.

@Martchus
Copy link
Contributor

Martchus commented May 9, 2022

Sounds a bit passive aggressive.

Sounds to me like @kalikiana is expressing he's not happy with the formulation (or would at least prefer a different one) and he's welcome to express it that way in my opinion. By the way, I don't care much but I find "Reinstate …" also better (if it is still stated in the commit message that it is "just" a revert of a certain commit).

@kalikiana kalikiana force-pushed the revert-35-revert-34-fix/heartbeat branch from 496ff5c to cf51670 Compare May 12, 2022 14:38
@kalikiana kalikiana closed this May 12, 2022
@okurz okurz deleted the revert-35-revert-34-fix/heartbeat branch May 12, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants