Fix order of arguments to _decode_content #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Oct 26, 2021
|
Yeah but we also don't have any instructions on testing manually. Maybe we should add some. |
|
Thanks for this fix. In #180 (review) I brought this up but @kalikiana repeatedly "resolved" the discussion without actually fixing it and in the end ignoring my request for change introducing this problem. That is the sad part EDIT: Actually disregard, I was wrong and overlooked the additions to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/101478
I assume since the
_getmethod has# pragma: no coverthat the whole method isn't covered, so the line with the wrong order was never called.