Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match second drive for partitioning_firstdisk #376

Closed
wants to merge 1 commit into from

Conversation

mloviska
Copy link
Contributor

@mloviska mloviska commented May 29, 2018

Whenever a hdd is used as an installation medium, it should not be offered as a storage for new OS. In other words partitioner does not propose installation medium as a suitable storage for deployment of OS.
Partitioner skips this hdd offer in case there are used only 2 hdds and of them is installation medium.

OpenQA test variable NUMDISKS should be updated to use 3 hdds.

Copy link
Contributor

@kravciak kravciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are lying about tag name :) - hard-disk-dev-sdb-selected matches /dev/vdc disk

@okurz
Copy link
Member

okurz commented Jun 8, 2018

yeah, that's sneaky ;)

@mloviska
Copy link
Contributor Author

Yeap, it is. :D However we do not need this needle anyway.

@okurz
Copy link
Member

okurz commented Jun 11, 2018

So close PR?

@mloviska
Copy link
Contributor Author

I am not really sure what we can do with it. But basically yes, we can.

@okurz okurz closed this Jun 11, 2018
@okurz
Copy link
Member

okurz commented Jun 11, 2018

OK, I did. You can also close PRs on your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants