myjsonrpc: Go back to incremental parsing #1248
Conversation
There was a problem hiding this comment.
The commit message could have a bit more details, e.g. what issue is fixed, why this needs to change, to which versions of which product it applies, link to a bug or a fate entry, the choices you made, etc. Please also describe in your git commit message in more details what is fixed without relying solely on the ticket.
The strategy to look for the next newline was too slow. The time for read_json() increased to about 4-5 times with the changes introduced in os-autoinst#1230 ec50b87 https://progress.opensuse.org/issues/58823 "os-autoinst is too slow pressing F2 causing ARM tests to fail in "boot_to_desktop" The write_json seemed to fail sometimes because the read took too long, resulting in test failures.
perlpunk
force-pushed
the
myjsonrpc-incr
branch
from
67bc782
to
6ceed99
Compare
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 38.39% 39.91% +1.51%
==========================================
Files 40 40
Lines 4956 4948 -8
Branches 846 844 -2
==========================================
+ Hits 1903 1975 +72
+ Misses 2712 2630 -82
- Partials 341 343 +2
Continue to review full report at Codecov.
|
I added info to the commit message. Not sure what I should add. Maybe @Martchus has suggestions? |
|
Thanks for the quick merge and the added details in the commit message |
The strategy to look for the next newline was too slow.
The time for
read_json()increased to about 4-5 times with the changes introduced in #1230https://progress.opensuse.org/issues/58823 "os-autoinst is too slow pressing F2 causing ARM tests to fail in "boot_to_desktop"
The
write_jsonseemed to fail sometimes because the read took too long, resulting in test failures.