-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to localStorage settings adapter (#159) #160
Conversation
7402d2f
to
c067798
Compare
b813441
to
a378077
Compare
Opsie. Just realized I stashed the |
a378077
to
63a818e
Compare
Avoid parsing of localStorage entries that does not contains a configured prefix because it could contain data that has been set in other applications under the same host.
63a818e
to
ba523c1
Compare
Is this and #159 still in need of any assistance? I've made some modifications to my fork of the localStorage adapter so I feel pretty comfortable with it if you need me to look at/add anything. About to go on vacation but if so I will check back when I return home. |
I can't remember working on this... but since it's still open I assume that it's not finished, so any help is appreciated @ajmeese7 . |
I just tried this out in my implementation of the library and it seems to work exactly as intended. I added some additional documentation to my |
The only thing that has not been solved is some kind of migration support so that settings are not lost with an update. But not really sure that's really needed. Maybe just a notice in the release notes will do. |
I agree, if the user requires that the old The release notes mention should be a perfect solution to this. |
Avoid parsing of localStorage entries that does not contains a
configured prefix because it could contain data that has been set in
other applications under the same host.