Fixes bare header redirect #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the browser will fail to redirect away from the login page if the client's browser doesn't allow for location mutations with the 422 response code. This issue only impacts SSO auth plugins.
|
Fixes #2397 |
protich
added a commit
that referenced
this pull request
Oct 14, 2015
Fixes bare header redirect Reviewed-By: Peter Rotich <peter@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the browser will fail to redirect away from the login page if the client's browser doesn't allow for location mutations with the 422 response code. This was triggered since there was no exit call after the bare header mutation. Using the HTTP#redirect call solves this problem.
This issue only impacted SSO auth plugins.