PHP 7.2 Compatibility #4680
Merged
PHP 7.2 Compatibility #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the Ticket filter system slightly less terrible. It could definitely use more polishing.
….8 into issue/php72
Ensure that saving Filter Actions aligns with the recent changes made to correct validations.
MPDF updated from version 5.7.3 to version 6.1 using composer.
MPDF updated from version 6.1 to version 7.1 using composer. Note: Lower versions of php will only support up to version 6.1 however, you must use at least version 7.1 for php v7.2
This commit modifies class.pdf.php to make sure it is compatible with the newest version of MPDF.
Conflicts: include/class.filter.php
This commit makes Primary Queues buckets for sub queues with forced inheritance of criteria. Primary queues are now hidden unless there are no sub queues attached. Agents can still get to primary queue by clicking on it. The commit also adds default sub queues for Closed queue, utilizing DateTime periods.
Conflicts: include/class.filter.php
Merge develop-next
…Ticket into protich-feature/custom-queues++
Protich feature/custom queues++
This commit fixes an issue where we assumed that we rules would always be passed in as arrays when validating rules.
Conflicts: include/client/open.inc.php include/staff/templates/user-lookup.tmpl.php
Reviewed By: aydreeihn <adriane@enhancesoft.com>
Reviewed By: aydreeihn <adriane@enhancesoft.com>
This commit fixes an issue where we did not correctly change the values passed to the render function that was updated to work with PHP 7.1
Codebase Updates
- Pull latest code from osTicket - Fix Filter ORM compatibility issues that resulted from merge
… into issue/php72 This commit makes osTicket compatible with PHP 7.2 Conflicts: include/class.filter.php
aydreeihn
force-pushed
the
issue/php72
branch
from
f2a54f1
to
8c7ca4a
Compare
|
Awesome! Will give it a try in a couple of days. Thank You!!! |
|
anyone tryed with 7.2 php ? thank you |
|
I'm running osTicket with 7.2 and have been since it 1.11 was released. You will see a lot of: |
JoshBeckerPLCH
pushed a commit
to plch/osTicket
that referenced
this pull request
Feb 28, 2020
PHP 7.2 Compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes osTicket compatible with PHP versions 5.6 - 7.2