HTML ticket thread, inline images and draft support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 9, 2013 16:31
Process inline attachments in thread entry and support inline images in
piped emails
Support inline images across the system, with draft support
Migrate to a single attachment table
That way we don't need a new table for everything we need to attach an
inline image to (like a signature, for instance)
Add richtext support for internal notes
Implement images on site pages
* Image paste in Redactor
* Make non-local images optional
* Placeholder for non-local images
* Fix local image download hover
* Don't re-attach inline images
Ticket notice and ticket auto-reply should not be formatted inside a table
since the %{message} or %{response} should be allowed to flow freely in the
email rather than be crammed inside the table.
This patch changes the behavior of the mailer to support a 'text' option to hint if the message is a text-only message. If so, no HTML processing will be performed on the message and a text-only email (with no inline attachments) will be emitted and sent.
protich
added a commit
that referenced
this pull request
Oct 9, 2013
HTML ticket thread, inline images and draft support Reviewed-By: Peter Rotich <peter@osticket.com>
Closed
Closed
ghost
mentioned this pull request
Closed
Closed
kurtbr
pushed a commit
to kurtbr/osTicket
that referenced
this pull request
Dec 11, 2019
I get an OrmException as field `last_update` doesn't exist, but `lastupdate` does, so it's likely just a typo.
```
/var/www/html/osticket/include/class.orm.php:382
Stack trace:
#0 /var/www/htm
l/osticket/include/class.orm.php(386): VerySimpleModel->get('last_update', NULL)
#1 /var/www/html/osticket/include/class.ticket.php(1881): VerySimpleModel->__g
et('last_update')
osTicket#2 /var/www/html/osticket/include/class.variable.php(89): Tic
ket->getVar('last_update', Object(VariableReplacer))
osTicket#3 /var/www/html/osticket/
include/class.variable.php(134): VariableReplacer->getVar(Object(Ticket), 'last_
update')
osTicket#4 /var/www/html/osticket/include/class.variable.php(168): VariableRep
lacer->_resolveVar('ticket.last_upd...')
osTicket#5 /var/www/html/osticket/include/clas
s.variable.php(115): VariableReplacer->_parse('Hi %{ticket.nam...')
osTicket#6 [interna
l function]: VariableReplacer->replaceVars('Hi %{ticket.nam...')
osTicket#7 /var/www/ht
ml/osticket/include/class.variable.php(113): array_map(Array, Array)
osTicket#8 /var/ww
w/html/osticket/include/class.osticket.php(147): VariableReplacer->replaceVars(A
rray)
osTicket#9 / in /var/www/html/osticket/include/class.orm.php on line 382, referer
: http://localhost:8080/scp/tickets.php?id=47```
Removing that underscore, no error, works fine.
Closed
JoshBeckerPLCH
pushed a commit
to plch/osTicket
that referenced
this pull request
Feb 28, 2020
I get an OrmException as field `last_update` doesn't exist, but `lastupdate` does, so it's likely just a typo.
```
/var/www/html/osticket/include/class.orm.php:382
Stack trace:
#0 /var/www/htm
l/osticket/include/class.orm.php(386): VerySimpleModel->get('last_update', NULL)
#1 /var/www/html/osticket/include/class.ticket.php(1881): VerySimpleModel->__g
et('last_update')
#2 /var/www/html/osticket/include/class.variable.php(89): Tic
ket->getVar('last_update', Object(VariableReplacer))
osTicket#3 /var/www/html/osticket/
include/class.variable.php(134): VariableReplacer->getVar(Object(Ticket), 'last_
update')
osTicket#4 /var/www/html/osticket/include/class.variable.php(168): VariableRep
lacer->_resolveVar('ticket.last_upd...')
osTicket#5 /var/www/html/osticket/include/clas
s.variable.php(115): VariableReplacer->_parse('Hi %{ticket.nam...')
osTicket#6 [interna
l function]: VariableReplacer->replaceVars('Hi %{ticket.nam...')
osTicket#7 /var/www/ht
ml/osticket/include/class.variable.php(113): array_map(Array, Array)
osTicket#8 /var/ww
w/html/osticket/include/class.osticket.php(147): VariableReplacer->replaceVars(A
rray)
osTicket#9 / in /var/www/html/osticket/include/class.orm.php on line 382, referer
: http://localhost:8080/scp/tickets.php?id=47```
Removing that underscore, no error, works fine.
JoshBeckerPLCH
pushed a commit
to plch/osTicket
that referenced
this pull request
Feb 28, 2020
Reviewed By: aydreeihn <adriane@enhancesoft.com>
Open
3 tasks
Open
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fundamental change to the message processing engine for osTicket
This enables (optionally) HTML for the ticket thread, as well as for canned responses and email templates. It also ships with a new set of HTML templates sporting a nice-looking theme.
The ticket thread is now equipped with inline image support. Images sent as inline attachments in emails or uploaded directly via the web interface or API are shown inline in the ticket thread, with optional download links.
The proprietary Redactor editor is used in place of the nicEditor used previously due to better handling of images
Outstanding
Placeholder image placement for external images