Add support for UTF character base types #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `drgn` did not recognize the `DW_ATE_UTF` encoding for base types, and consequently could not handle `char8_t`, `char16_t`, or `char32_t`. This has been remedied, and a corresponding test case added to prevent regressions. Signed-off-by: Kevin Svetlitski <svetlitski@fb.com>
ghost
ajor
approved these changes
Jul 6, 2022
|
Looks good to me but I missed which repo this was when I left my review - sorry! |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
drgndid not recognize theDW_ATE_UTFencoding for base types, and consequently could not handle the UTF character types defined by C++ (i.e.char8_t,char16_t, andchar32_t). This has been remedied, and a corresponding test case added to prevent regressions.