Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should not use a workspace build #1254

Closed
lwrage opened this issue May 23, 2018 · 1 comment
Closed

Tests should not use a workspace build #1254

lwrage opened this issue May 23, 2018 · 1 comment
Assignees
@lwrage @sprocter
Labels
category:enhancement core importance:high
Milestone
2.3.4

Comments

@lwrage
Copy link
Contributor

lwrage commented May 23, 2018 •
edited
Loading

Currently, tests depend on running in a workspace. We create files in the workspace and do a build, which takes about 4s per test.

child of #1018
blocked by #1255
@lwrage lwrage added this to the 2.3.4 milestone May 23, 2018
@lwrage lwrage self-assigned this May 23, 2018
@lwrage lwrage mentioned this issue May 25, 2018
Closed
@lwrage
Copy link
Contributor Author

lwrage commented May 30, 2018

Use a test resource set instead of the workspace, preload contributed packages and property sets as needed.

@joeseibel joeseibel mentioned this issue May 30, 2018
Closed
This was referenced May 31, 2018
Closed
Merged
@ghost ghost added review and removed in progress labels Jun 1, 2018
@lwrage lwrage mentioned this issue Jun 7, 2018
Closed
@ghost ghost assigned sprocter Jun 11, 2018
@ghost ghost removed the review label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lwrage lwrage

@sprocter sprocter

Labels
category:enhancement core importance:high
Projects
None yet
Milestone
2.3.4
Development

No branches or pull requests
2 participants
@lwrage @sprocter