Use packaged Fedora IoT remote configuration #95
Conversation
achilleas-k
force-pushed
the
iot-remote
branch
from
c3aea43
to
1df15b2
Compare
achilleas-k
force-pushed
the
iot-remote
branch
from
1df15b2
to
29d5ae8
Compare
|
Hi @achilleas-k, |
|
The purpose of this PR is to configure the default remote for the image by installing an RPM that's managed by the Fedora IoT team rather than having it as part of the image definition. This is similar to how RPM repositories are configured in RPM-based images: we don't configure repositories ourselves, but they are packaged and distributed by the distribution and we install them in our images. I'm not sure we need to test that a particular remote configuration is present. Perhaps we can have a check that there is a remote configured (any remote). But more specifically, there was an issue the last time we tried to make this change that blocked us [1]. The tests we have in osbuild-composer were failing when setting up a custom remote in order to test the upgrade commit. We still haven't figured out what's causing this issue and how the change affects it. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
achilleas-k
force-pushed
the
iot-remote
branch
from
29d5ae8
to
b7f0950
Compare
|
@paulwhalen you were looking at this from the Fedora side, right? |
|
In ostreedev/ostree#3079 I believe |
Yes, working on the |
achilleas-k
force-pushed
the
iot-remote
branch
from
b7f0950
to
7133d33
Compare
achilleas-k
force-pushed
the
iot-remote
branch
from
7133d33
to
b25b4e9
Compare
|
The remote issue should be fixed now! |
Add the same comment that we have in the osbuild stage schema.
The default remote is packaged in the fedora-iot-config rpm and configured for all fedora-iot images. Remove the static configuration from iot-raw-image, iot-qcow2-image, and iot-simplified-installer. Keep the remote name set so that the deploy stage sets the remote to track for the deployment.
When we want the source URL to be set as the remote for the system, we define it at the distro level. In the pipeline, if no remote URL is set, don't add a remote stage at all.
achilleas-k
force-pushed
the
iot-remote
branch
from
b25b4e9
to
a0dbb6b
Compare
|
I'm going to merge this and move on to getting it into osbuild-composer. My local tests worked so we'll have to catch any other issues in CI there. |
Migration of osbuild/osbuild-composer#3488.
The default Fedora IoT remote is packaged in the
fedora-iot-configpackage. This PR removes the ostree remote config we hard coded for theiot-raw-image(and associated image typesiot-qcow2-imageandiot-simplified-installer) and installs the package in theiot-commit, which means every Fedora IoT build (both commit and container) are configured using the package.