Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added base Header-Footer #14

Merged
merged 5 commits into from
Jan 24, 2021
Merged

Added base Header-Footer #14

merged 5 commits into from
Jan 24, 2021

Conversation

Sudhee-bsp
Copy link
Contributor

@Sudhee-bsp Sudhee-bsp commented Jan 21, 2021 •
edited
Loading

  • Added the static support for dashboard app - which includes css, js, images

  • Base version of Header (navbar) and footer are added.

  • These are created as Base Templates that can be used for the rest of the app templates

  • All the navigation links to connecting apps will be added

ssgif-1

@thekodeking thekodeking added the front end Anything related to the front end must have this tag attached to it. label Jan 21, 2021
dat-adi
dat-adi requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header and footer both look presentable as of right now, however, these are the changes that are yet to be worked on.

  • Base HTML Template Extension of the header and footer.
  • Extension of Base to rest of the applications.

@Sudhee-bsp Sudhee-bsp mentioned this pull request Jan 22, 2021
Closed
3 tasks
@Sudhee-bsp Sudhee-bsp linked an issue Jan 22, 2021 that may be closed by this pull request
Template extension using base html #21
Closed
3 tasks
@Sudhee-bsp Sudhee-bsp self-assigned this Jan 22, 2021
dat-adi
dat-adi reviewed Jan 24, 2021
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate changes have been made to the base.html.

@dat-adi
Copy link
Member

dat-adi commented Jan 24, 2021

This issue and PR will be closed as soon as the Header and Footer are added to all the templates.
The change requested,

  • Addition of content from the backend for events, user profiles, and livestreams. @kode-logger @bhargavd2

can be created as another issue, with a separate PR.

@dat-adi dat-adi merged commit 66dee0c into master Jan 24, 2021
SVijayB pushed a commit that referenced this pull request Jul 26, 2021
@dat-adi
Merge pull request #14 from Open-Source-Community-VIT-AP/frontdev
cc8ba2f 
Added base Header-Footer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dat-adi dat-adi dat-adi approved these changes

Assignees

@Sudhee-bsp Sudhee-bsp

Labels
front end Anything related to the front end must have this tag attached to it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template extension using base html
3 participants
@Sudhee-bsp @dat-adi @thekodeking