Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-Editor: Use Monaco instead of Ace #256

Closed
ericfranz opened this issue Jun 20, 2016 · 4 comments
Closed

File-Editor: Use Monaco instead of Ace #256

ericfranz opened this issue Jun 20, 2016 · 4 comments
Labels
component/file_editor enhancement This is functionality that builds upon existing functionality. needs decision Paths ahead known, but choice on which to pursue needed. needs investigation
Milestone

Comments

@ericfranz
Copy link
Contributor

ericfranz commented Jun 20, 2016

Version 2 of the editor could use Monaco instead of Ace

https://microsoft.github.io/monaco-editor/index.html

This has a diff mode that could be very useful, and auto-complete.

┆Issue is synchronized with this Asana task by Unito

@brianmcmichael
Copy link
Contributor

This would need to have a discussion about cost/benefit.

I'm not sure if the API is as mature as Ace's, and we'd need to decide what could be gained by this versus what we'd lose.

@ericfranz
Copy link
Contributor Author

Some conversation threads related to monaco vs ace, other can be found https://news.ycombinator.com/item?id=11939557

@ericfranz
Copy link
Contributor Author

@MorganRodgers MorganRodgers changed the title Use Monaco instead of Ace File-Editor: Use Monaco instead of Ace Nov 12, 2019
@MorganRodgers MorganRodgers transferred this issue from OSC/ood-fileeditor Nov 12, 2019
@ericfranz ericfranz added this to the Backlog milestone Jan 30, 2020
@lukew3 lukew3 added enhancement This is functionality that builds upon existing functionality. needs investigation needs decision Paths ahead known, but choice on which to pursue needed. labels Jun 30, 2022
@johrstrom
Copy link
Contributor

I can't imagine us getting around to this anytime soon, so I'm going to close at this time. We can revisit at some point in the future if cycles free up and we're interested in it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/file_editor enhancement This is functionality that builds upon existing functionality. needs decision Paths ahead known, but choice on which to pursue needed. needs investigation
Projects
None yet
Development

No branches or pull requests

5 participants