Merge pull request #839 from HereAround/Cache

Cache computed properties for toric varieties

docs/src/ToricVarieties/NormalToricVarieties.md

@@ -86,6 +86,7 @@ cartier_divisor_group(v::AbstractNormalToricVariety)
 character_lattice(v::AbstractNormalToricVariety)
 class_group(v::AbstractNormalToricVariety)
 map_from_cartier_divisor_group_to_torus_invariant_divisor_group(v::AbstractNormalToricVariety)
+map_from_cartier_divisor_group_to_picard_group(v::AbstractNormalToricVariety)
 map_from_character_to_principal_divisors(v::AbstractNormalToricVariety)
 map_from_weil_divisors_to_class_group(v::AbstractNormalToricVariety)
 picard_group(v::AbstractNormalToricVariety)
@@ -108,7 +109,7 @@ nef_cone(v::NormalToricVariety)
 dim(v::AbstractNormalToricVariety)
 dim_of_torusfactor(v::AbstractNormalToricVariety)
 euler_characteristic(v::AbstractNormalToricVariety)
-ith_betti_number(v::AbstractNormalToricVariety, i::Int)
+betti_number(v::AbstractNormalToricVariety, i::Int)
 ```
 
 ### Rings and ideals

docs/src/ToricVarieties/ToricDivisors.md

@@ -43,4 +43,5 @@ isvery_ample(td::ToricDivisor)
 ```@docs
 coefficients(td::ToricDivisor)
 polyhedron(td::ToricDivisor)
+toricvariety(td::ToricDivisor)
 ```

src/ToricVarieties/CyclicQuotientSingularities/CyclicQuotientSingularities.jl

@@ -4,7 +4,7 @@
 ################################################################################
 ################################################################################
 
-struct CyclicQuotientSingularity <: AbstractNormalToricVariety
+@attributes mutable struct CyclicQuotientSingularity <: AbstractNormalToricVariety
     polymakeNTV::Polymake.BigObject
 end
 export CyclicQuotientSingularity
@@ -25,7 +25,7 @@ $0<q<n$ and $q,n$ coprime.
 # Examples
 ```jldoctest
 julia> cqs = CyclicQuotientSingularity(7,5)
-A normal toric variety corresponding to a polyhedral fan in ambient dimension 2
+A normal toric variety
 
 julia> isaffine(cqs)
 true
@@ -40,7 +40,7 @@ function CyclicQuotientSingularity(n::fmpz, q::fmpz)
     q < n || error("q must be smaller than n (q=$(q) >= n=$(n))")
     gcd(n,q)==1 || error("n and q must be coprime (gcd=$(gcd(n,q)))")
     pmntv = Polymake.fulton.CyclicQuotient(N=convert(Polymake.Integer, n), Q=convert(Polymake.Integer, q))
-    return CyclicQuotientSingularity(pmntv)
+    return CyclicQuotientSingularity(pmntv, Dict())
 end
 CyclicQuotientSingularity(n::Int64, q::Int64) = CyclicQuotientSingularity(fmpz(n), fmpz(q))
 
@@ -60,7 +60,7 @@ differs in sign from what is commonly known as continued fraction.
 # Examples
 ```jldoctest
 julia> cqs = CyclicQuotientSingularity(7,5)
-A normal toric variety corresponding to a polyhedral fan in ambient dimension 2
+A normal toric variety
 
 julia> cf = continued_fraction_hirzebruch_jung(cqs)
 3-element Vector{fmpz}:
@@ -72,7 +72,11 @@ julia> ecf = cf[1]-1//(cf[2]-fmpq(1,cf[3]))
 7//5
 ```
 """
-continued_fraction_hirzebruch_jung(cqs::CyclicQuotientSingularity) = Vector{fmpz}(pm_object(cqs).CONTINUED_FRACTION)
+function continued_fraction_hirzebruch_jung(cqs::CyclicQuotientSingularity)
+    return get_attribute!(cqs, :continued_fraction_hirzebruch_jung) do
+        return Vector{fmpz}(pm_object(cqs).CONTINUED_FRACTION)
+    end
+end
 export continued_fraction_hirzebruch_jung
 
 
@@ -91,7 +95,7 @@ differs in sign from what is commonly known as continued fraction.
 # Examples
 ```jldoctest
 julia> cqs = CyclicQuotientSingularity(7,5)
-A normal toric variety corresponding to a polyhedral fan in ambient dimension 2
+A normal toric variety
 
 julia> dcf = dual_continued_fraction_hirzebruch_jung(cqs)
 2-element Vector{fmpz}:
@@ -102,7 +106,11 @@ julia> edcf = dcf[1] - fmpq(1,dcf[2])
 7//2
 ```
 """
-dual_continued_fraction_hirzebruch_jung(cqs::CyclicQuotientSingularity) = Vector{fmpz}(pm_object(cqs).DUAL_CONTINUED_FRACTION)
+function dual_continued_fraction_hirzebruch_jung(cqs::CyclicQuotientSingularity)
+    return get_attribute!(cqs, :dual_continued_fraction_hirzebruch_jung) do
+        return Vector{fmpz}(pm_object(cqs).DUAL_CONTINUED_FRACTION)
+    end
+end
 export dual_continued_fraction_hirzebruch_jung
 
 
@@ -120,7 +128,7 @@ differs in sign from what is commonly known as continued fraction.
 # Examples
 ```jldoctest
 julia> cqs = CyclicQuotientSingularity(7,5)
-A normal toric variety corresponding to a polyhedral fan in ambient dimension 2
+A normal toric variety
 
 julia> v = continued_fraction_hirzebruch_jung(cqs)
 3-element Vector{fmpz}:

src/ToricVarieties/JToric.jl

@@ -1,5 +1,5 @@
-include("NormalToricVarieties/auxilliary.jl")
 include("NormalToricVarieties/constructors.jl")
+include("NormalToricVarieties/auxilliary.jl")
 include("NormalToricVarieties/properties.jl")
 include("NormalToricVarieties/attributes.jl")
 include("NormalToricVarieties/methods.jl")
@@ -8,6 +8,7 @@ include("CyclicQuotientSingularities/CyclicQuotientSingularities.jl")
 
 include("ToricDivisors/constructors.jl")
 include("ToricDivisors/properties.jl")
+include("ToricDivisors/attributes.jl")
 
 include("LineBundles/constructors.jl")
 include("LineBundles/attributes.jl")

src/ToricVarieties/LineBundles/constructors.jl

@@ -20,7 +20,6 @@ export ToricLineBundle
     ToricLineBundle(v::AbstractNormalToricVariety, c::Vector{fmpz})
 
 Construct the line bundle on the abstract normal toric variety `v` with class `c`.
-```
 """
 function ToricLineBundle(v::AbstractNormalToricVariety, input_class::Vector{fmpz})
     class = picard_group(v)(input_class)
@@ -35,7 +34,7 @@ Convenience method for ToricLineBundle(v::AbstractNormalToricVariety, c::Vector{
 # Examples
 ```jldoctest
 julia> v = toric_projective_space(2)
-A normal toric variety corresponding to a polyhedral fan in ambient dimension 2
+A normal, non-affine, smooth, projective, gorenstein, q-gorenstein, fano, 2-dimensional toric variety without torusfactor
 
 julia> l = ToricLineBundle( v, [ 2 ] )
 A line bundle on a normal toric variety corresponding to a polyhedral fan in ambient dimension 2