New file with module types #1013
Conversation
|
There are a gazillion pointless merge commits in this PR, so either we squash-merge this, or the PR history is rewritten before merge to get rid of these (e.g. by @AlexD97 squashing everything into a single commit based on latest master) |
|
It is really hard to see what's going on, as you move code, and modify it, all in one go; the individual commits are no help easier. It'd be much easier if there were two commits: one that moves all the code into the new file, but doesn't modify it otherwise; and a second which performs the actual modification. As it is, I don't think there is an effective way to review this PR, we just have to trust you |
| @doc Markdown.doc""" | ||
| ModuleFP{T} | ||
|
|
||
| The abstract supertype of all modules. Here, all modules are finitely presented. |
There was a problem hiding this comment.
Isn't an oxymoron? So perhaps:
| The abstract supertype of all modules. Here, all modules are finitely presented. | |
| The abstract supertype of all finitely presented modules. |
| ModuleFP{T} | ||
|
|
||
| The abstract supertype of all modules. Here, all modules are finitely presented. | ||
| The type variable `T` refers to the type of the elements of the base ring. |
There was a problem hiding this comment.
Good, ideally all our type docstrings should explain the meaning of the various type parameters :-)
| @doc Markdown.doc""" | ||
| AbstractFreeMod{T} <: ModuleFP{T} | ||
|
|
||
| The abstract supertype of all free modules. |
There was a problem hiding this comment.
| The abstract supertype of all free modules. | |
| The abstract supertype of all finitely generated free modules. |
| @doc Markdown.doc""" | ||
| AbstractSubQuo{T} <: ModuleFP{T} | ||
|
|
||
| The abstract supertype of all subquotient modules. |
There was a problem hiding this comment.
| The abstract supertype of all subquotient modules. | |
| The abstract supertype of all finitely presented subquotient modules. |
| @doc Markdown.doc""" | ||
| AbstractFreeModElem{T} <: ModuleFPElem{T} | ||
|
|
||
| The abstract supertype of all elements of free modules. |
There was a problem hiding this comment.
| The abstract supertype of all elements of free modules. | |
| The abstract supertype of all elements of finitely generated free modules. |
The module types are in a new file.
Moreover, hom for free graded modules is implemented.