-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Singular function minbase
for homogeneous ideals
#1191
Conversation
So, I am going to have to do a new Singular.jl release very soon. Any chance you can put this in the correct place (Singular.jl)? |
Also, it looks like at least two things are going wrong with singular in the tests. |
It's probably my fault, but I haven't looked into it yet. |
Okay, sure. |
It would be good, if one could check whether an ideal is homogeneous in Singular.jl for this, but I couldn't find a function for that. In Singular there is |
So yeah, it was my fault (and not Singular's). |
There is no equivalent of |
In Singular, there is also the more general isHomogeneous from multigrading.lib |
Then I don't see what I can do on the Singular.jl side. One only needs to extend the check in line https://github.com/oscar-system/Singular.jl/blob/e2d8e79e44af39119559181a0437970f3b062f8f/src/ideal/ideal.jl#L915 to also allow homogeneous ideals when |
Alright. Just keep it here, and I'll open an issue for moving it eventually. |
Am Mon, Mar 21, 2022 at 11:39:45PM -0700 schrieb Wolfram Decker:
In Singular, there is also the more general isHomogeneous from
multigrading.lib
But multigrading.lib uses Singulars attributes which we do not have in
libsingular-julia/Singular.jl/Oscar
|
3729c7a
to
20a51b2
Compare
This introduces
minimal_generating_set
for homogeneous ideals using Singular'sminbase
.Also makes sure that the
singular_poly_ring
constructed from aMPolyRing_dec
is given a weighted monomial ordering corresponding to the grading if the grading is given by positive (or negative) weights.Resolves #886 as far as I'm concerned.
Note that
minbase
is also wrapped in Singular.jl, but only for local orderings.