Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Singular function minbase for homogeneous ideals #1191

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

joschmitt
Copy link
Member

This introduces minimal_generating_set for homogeneous ideals using Singular's minbase.
Also makes sure that the singular_poly_ring constructed from a MPolyRing_dec is given a weighted monomial ordering corresponding to the grading if the grading is given by positive (or negative) weights.
Resolves #886 as far as I'm concerned.
Note that minbase is also wrapped in Singular.jl, but only for local orderings.

@tthsqe12
Copy link
Contributor

So, I am going to have to do a new Singular.jl release very soon. Any chance you can put this in the correct place (Singular.jl)?

@tthsqe12
Copy link
Contributor

tthsqe12 commented Mar 21, 2022

Also, it looks like at least two things are going wrong with singular in the tests.
I will investigate.

@joschmitt
Copy link
Member Author

Also, it looks like at least two things are going wrong with singular in the tests. I will investigate.

It's probably my fault, but I haven't looked into it yet.

@joschmitt
Copy link
Member Author

So, I am going to have to do a new Singular.jl release very soon. Any chance you can put this in the correct place (Singular.jl)?

Okay, sure.

@joschmitt joschmitt marked this pull request as draft March 21, 2022 16:04
@joschmitt
Copy link
Member Author

So, I am going to have to do a new Singular.jl release very soon. Any chance you can put this in the correct place (Singular.jl)?

It would be good, if one could check whether an ideal is homogeneous in Singular.jl for this, but I couldn't find a function for that. In Singular there is homog; how do I use this in Singular.jl?

@joschmitt
Copy link
Member Author

Also, it looks like at least two things are going wrong with singular in the tests. I will investigate.

It's probably my fault, but I haven't looked into it yet.

So yeah, it was my fault (and not Singular's).

@tthsqe12
Copy link
Contributor

So, I am going to have to do a new Singular.jl release very soon. Any chance you can put this in the correct place (Singular.jl)?

It would be good, if one could check whether an ideal is homogeneous in Singular.jl for this, but I couldn't find a function for that. In Singular there is homog; how do I use this in Singular.jl?

There is no equivalent of homog in Singular.jl yet because the corresponding code is missing from libsingular_julia.jll. It would would have to be written, and then we can use it in the next version of libsingular_julia.jll.
oscar-system/libsingular-julia#54

@wdecker
Copy link
Collaborator

wdecker commented Mar 22, 2022

@joschmitt

In Singular, there is also the more general isHomogeneous from multigrading.lib

@joschmitt
Copy link
Member Author

Then I don't see what I can do on the Singular.jl side. One only needs to extend the check in line https://github.com/oscar-system/Singular.jl/blob/e2d8e79e44af39119559181a0437970f3b062f8f/src/ideal/ideal.jl#L915 to also allow homogeneous ideals when homog is available.
(In principle, idMinBase allows all kind of ideals, but will print
// minbase applies only to the local or homogeneous case over coefficient fields
if it doesn't like the input.)

@joschmitt joschmitt marked this pull request as ready for review March 22, 2022 08:19
@tthsqe12
Copy link
Contributor

Alright. Just keep it here, and I'll open an issue for moving it eventually.

@hannes14
Copy link
Member

hannes14 commented Mar 22, 2022 via email

@joschmitt joschmitt force-pushed the minbase branch 2 times, most recently from 3729c7a to 20a51b2 Compare March 28, 2022 08:43
@joschmitt joschmitt marked this pull request as draft March 28, 2022 11:39
@joschmitt joschmitt marked this pull request as ready for review March 28, 2022 12:27
@fieker fieker merged commit 1f465d7 into oscar-system:master Mar 30, 2022
@joschmitt joschmitt deleted the minbase branch March 30, 2022 06:58
wdecker added a commit that referenced this pull request Mar 31, 2022
fieker added a commit that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make singular_ring remember the grading?
5 participants