Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong usage of // #1371

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Fix wrong usage of // #1371

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a46ca6
Fix wrong usage of //
thofma Jun 3, 2022
671de29
Update experimental/PlaneCurve/AffinePlaneCurve.jl
thofma Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions experimental/PlaneCurve/AffinePlaneCurve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ function curve_intersect(C::AffinePlaneCurve{S}, D::AffinePlaneCurve{S}) where S
# The constant coefficient is stored as a mpoly to be used later in evaluate.
for g in keys(Z.fac)
if total_degree(g) == 1
f = g//leading_coefficient(g)
f = divexact(g, leading_coefficient(g))
@show typeof(f)
@show typeof(gen(R, 2))
thofma marked this conversation as resolved.
Show resolved Hide resolved
push!(Y, -f + gen(R, 2))
end
end
Expand All @@ -181,7 +183,7 @@ function curve_intersect(C::AffinePlaneCurve{S}, D::AffinePlaneCurve{S}) where S
ZZ = factor(GG)
for g in keys(ZZ.fac)
if total_degree(g) == 1
f = g//leading_coefficient(g)
f = divexact(g, leading_coefficient(g))
# We use lc to convert the mpoly into element of S.
push!(L, [leading_coefficient(-f + gen(R, 1)), leading_coefficient(y)])
end
Expand Down