Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for AffineSchemes #1582

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Tests for AffineSchemes #1582

merged 6 commits into from
Sep 30, 2022

Conversation

simonbrandhorst
Copy link
Collaborator

And some bugfixes.

afkafkafk13
afkafkafk13 reviewed Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the two minor comments.

Just curiosity: Concerning the tests, how much of the functionality of AffineSchemes.jl is now covered by tests (approximately)?

experimental/Schemes/AffineSchemes.jl Outdated Show resolved Hide resolved
experimental/Schemes/AffineSchemes.jl Outdated Show resolved Hide resolved
@thofma
Copy link
Collaborator

thofma commented Sep 30, 2022 •
edited
Loading

https://app.codecov.io/gh/oscar-system/Oscar.jl/blob/master/experimental/Schemes/AffineSchemes.jl

63% (before this PR)

Once the tests pass, there will be a codecove/patch item showing up in the lists of checks below. Then one can inspect how the coverage changed.

@fingolfin
Copy link
Member

Once (if) tests pass, one also gets inline comments like this in the "Files" tab that indicates which lines modified by the PR are not covered. That can be useful: submit your code as a (draft) PR, see which parts are under tested, add tests, repeat.

Screenshot 2022-09-30 at 16 42 27

simonbrandhorst and others added 2 commits September 30, 2022 19:46
@simonbrandhorst @fingolfin
Update experimental/Schemes/AffineSchemes.jl
a57aa3b 
Co-authored-by: Max Horn <max@quendi.de>
@simonbrandhorst @fingolfin
Update experimental/Schemes/AffineSchemes.jl
2c25541 
Co-authored-by: Max Horn <max@quendi.de>
@simonbrandhorst simonbrandhorst enabled auto-merge (squash) September 30, 2022 17:54
@simonbrandhorst
Copy link
Collaborator Author

simonbrandhorst commented Sep 30, 2022 •
edited
Loading

Thank you for your comments. I set to auto merge. Once there is a single positive review.

@simonbrandhorst simonbrandhorst merged commit 9fcd83d into oscar-system:master Sep 30, 2022
@simonbrandhorst simonbrandhorst deleted the tests_schemes branch September 30, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@afkafkafk13 afkafkafk13 Awaiting requested review from afkafkafk13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonbrandhorst @thofma @fingolfin @afkafkafk13