Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache computed properties for toric varieties #839

Merged
merged 23 commits into from
Dec 29, 2021
Merged

Cache computed properties for toric varieties #839

merged 23 commits into from
Dec 29, 2021

Commits on Dec 21, 2021

  1. Improve method isprime_divisor

    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    77db348 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete code

    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    65d2fe7 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete whitespaces

    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0146254 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @fingolfin @HereAround
    fingolfin authored and HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    ac1f3a8 View commit details
    Browse the repository at this point in the history

  5. Use @attributes mutable struct for 

    (*) affine toric varieties
(*) normal toric varieties
(*) cyclic quotient singuarlties
    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a5a5b73 View commit details
    Browse the repository at this point in the history

  6. Cache properties of normal toric varieties

    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    3cce827 View commit details
    Browse the repository at this point in the history

  7. Cache attributes of normal toric varieties

    @HereAround
    HereAround committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    3470ef4 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Cache betti numbers of normal toric varieties 

    Change name of method: ith_betti_number -> betti_number
    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    0113ddb View commit details
    Browse the repository at this point in the history

  2. Cache attributes of cyclic quotient singularities

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    95bc6f5 View commit details
    Browse the repository at this point in the history

  3. Cache properties upon construction of normal toric variety

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    a95f3df View commit details
    Browse the repository at this point in the history

  4. Cache properties of toric projective space upon construction

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    9160c5a View commit details
    Browse the repository at this point in the history

  5. Improve computation of class group and Picard group

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    185f12d View commit details
    Browse the repository at this point in the history

  6. Add method map_from_cartier_divisor_group_to_picard_group 

    Improve computation of picard group
    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    ba7e75d View commit details
    Browse the repository at this point in the history

  7. Cache more attributes of toric projective space upon construction

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    6084b25 View commit details
    Browse the repository at this point in the history

  8. Cache properties of hirzebruch surfaces upon construction

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    8d271f6 View commit details
    Browse the repository at this point in the history

  9. Cache properties of del Pezzo surfaces upon construction

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    48a68f7 View commit details
    Browse the repository at this point in the history

  10. Update tests (otherwise, they test if caching worked upon construction)

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    35f6339 View commit details
    Browse the repository at this point in the history

  11. Cache computed quantities for toric divisors

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    6d7b636 View commit details
    Browse the repository at this point in the history

  12. Sophisticated show method for normal toric varieties

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    a87dfcd View commit details
    Browse the repository at this point in the history

  13. Sophisticated show method for toric divisors

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    604e71a View commit details
    Browse the repository at this point in the history

  14. Simplify code for saving/accessing cached information on toric varieties

    @HereAround
    HereAround committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    77aed33 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Fix bug "cannot assign value to Oscar variable rays" 

    Rename "rays" to "fan_rays"
    @HereAround
    HereAround committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    4f43fa4 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Improve method betti_number for normal toric variety 

    Co-authored-by: Max Horn <max@quendi.de>
    @HereAround @fingolfin
    HereAround and fingolfin authored Dec 29, 2021
    Configuration menu
    Copy the full SHA
    aaee3c9 View commit details
    Browse the repository at this point in the history