Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other minor improvements for toric varieties #940

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Other minor improvements for toric varieties #940

merged 7 commits into from
Jan 4, 2022

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jan 3, 2022 •
edited

  • Mention in documentation that the Cox ring is also known as total coordinate ring.
  • Add a constructor for the toric_affine_space.
  • Cache the toric ideal of a NormalToricVariety which is affine.
  • Replace abelian_group by free_abelian_group whenever possible.

This PR contains the changes in #929 for completeness.

@HereAround HereAround mentioned this pull request Jan 3, 2022
Merged
@HereAround HereAround changed the title Other minor improvements Other minor improvements for toric varieties Jan 3, 2022
@HereAround HereAround mentioned this pull request Jan 3, 2022
Merged
@fingolfin
Copy link
Member

PR #929 was merged, so please rebase.

HereAround and others added 3 commits January 4, 2022 11:14
@HereAround @fingolfin
' => " to improve documentation
c1c286e 
Co-authored-by: Max Horn <max@quendi.de>
@HereAround @fingolfin
Remove obsolete '
468e32c 
Co-authored-by: Max Horn <max@quendi.de>
@HereAround
Increase performance of constructor for toric_projective_space
83fa4c7
@HereAround
Copy link
Member Author

PR #929 was merged, so please rebase.

Done.

@HereAround
Copy link
Member Author

All tests green - that is how I like it. Please consider merging if you are satisfied.

@fingolfin fingolfin merged commit 395ed2c into oscar-system:master Jan 4, 2022
@HereAround HereAround deleted the OtherMinorImprovements branch March 7, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HereAround @fingolfin