Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcc version check to cmake #230

Merged
merged 1 commit into from
Mar 9, 2020
Merged

add gcc version check to cmake #230

merged 1 commit into from
Mar 9, 2020

Conversation

benlorenz
Copy link
Member

libcxxwrap-julia needs C++17 if constexpr (among other stuff) which requires gcc version at least 7.

@saschatimme
Copy link
Collaborator

We get a segfault on travis which uses 1.4-rc2, whereas gh actions only uses 1.4-rc1. This is a little bit concerning.

@benlorenz
Copy link
Member Author

benlorenz commented Mar 6, 2020 •
edited
Loading

This seems to be during precompilation of CxxWrap (build.jl line 1 is using CxxWrap) and there is nothing relevant from Polymake in the backtrace.

Update: travis is happy now after the rebuild.

PS: to preserve the log before I trigger a rebuild:

$ julia --color=yes -e "if VERSION < v\"0.7.0-DEV.5183\"; Pkg.clone(pwd()); Pkg.build(\"${JL_PKG}\"); else using Pkg; if VERSION >= v\"1.1.0-rc1\"; Pkg.build(verbose=true); else Pkg.build(); end; end"
    Cloning default registries into `~/.julia`
    Cloning registry from "https://github.com/JuliaRegistries/General.git"
      Added registry `General` to `~/.julia/registries/General`
   Updating registry at `~/.julia/registries/General`
   Updating git-repo `https://github.com/JuliaRegistries/General.git`
  Installed URIParser ────────── v0.4.0
  Installed Parsers ──────────── v0.3.12
  Installed CxxWrap ──────────── v0.9.0
  Installed OrderedCollections ─ v1.1.0
  Installed CMake ────────────── v1.2.0
  Installed BinaryProvider ───── v0.5.8
  Installed JSON ─────────────── v0.21.0
  Installed DataStructures ───── v0.17.10
  Installed MacroTools ───────── v0.5.4
  Installed BinDeps ──────────── v1.0.0
   Updating `~/build/oscar-system/Polymake.jl/Project.toml`
  [b99e7846] + BinaryProvider v0.5.8
  [631607c0] + CMake v1.2.0
  [1f15a43c] + CxxWrap v0.9.0
  [682c06a0] + JSON v0.21.0
  [8f399da3] + Libdl 
  [d6f4376e] + Markdown 
  [44cfe95a] + Pkg 
  [3fa0cd96] + REPL 
  [2f01184e] + SparseArrays 
   Updating `~/build/oscar-system/Polymake.jl/Manifest.toml`
  [9e28174c] + BinDeps v1.0.0
  [b99e7846] + BinaryProvider v0.5.8
  [631607c0] + CMake v1.2.0
  [1f15a43c] + CxxWrap v0.9.0
  [864edb3b] + DataStructures v0.17.10
  [682c06a0] + JSON v0.21.0
  [1914dd2f] + MacroTools v0.5.4
  [bac558e1] + OrderedCollections v1.1.0
  [69de0a69] + Parsers v0.3.12
  [30578b45] + URIParser v0.4.0
  [2a0f44e3] + Base64 
  [ade2ca70] + Dates 
  [8ba89e20] + Distributed 
  [b77e0a4c] + InteractiveUtils 
  [76f85450] + LibGit2 
  [8f399da3] + Libdl 
  [37e2e46d] + LinearAlgebra 
  [56ddb016] + Logging 
  [d6f4376e] + Markdown 
  [a63ad114] + Mmap 
  [44cfe95a] + Pkg 
  [de0858da] + Printf 
  [3fa0cd96] + REPL 
  [9a3f8284] + Random 
  [ea8e919c] + SHA 
  [9e88b42a] + Serialization 
  [6462fe0b] + Sockets 
  [2f01184e] + SparseArrays 
  [8dfed614] + Test 
  [cf7118a7] + UUIDs 
  [4ec0a83e] + Unicode 
   Building CxxWrap → `~/.julia/packages/CxxWrap/lDNAy/deps/build.log`
   Building CMake ──→ `~/.julia/packages/CMake/ULbyn/deps/build.log`
   Building CxxWrap ─→ `~/.julia/packages/CxxWrap/lDNAy/deps/build.log`
   Building CMake ───→ `~/.julia/packages/CMake/ULbyn/deps/build.log`
   Building Polymake → `~/build/oscar-system/Polymake.jl/deps/build.log`
signal (11): Segmentation fault
in expression starting at /home/travis/.julia/packages/CxxWrap/lDNAy/src/StdLib.jl:16
jl_object_id_ at /buildworker/worker/package_linux64/build/src/builtins.c:342
jl_object_id_ at /buildworker/worker/package_linux64/build/src/builtins.c:344
objectid at ./reflection.jl:312 [inlined]
protect_from_gc at /home/travis/.julia/packages/CxxWrap/lDNAy/src/CxxWrap.jl:319
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2158 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
unknown function (ip: 0x7f61c8c71273)
_ZN5jlcxx15protect_from_gcEP11_jl_value_t at /home/travis/.julia/packages/CxxWrap/lDNAy/deps/usr/lib/libcxxwrap_julia.so (unknown line)
_ZN5jlcxx6ModuleC2EP12_jl_module_t at /home/travis/.julia/packages/CxxWrap/lDNAy/deps/usr/lib/libcxxwrap_julia.so (unknown line)
_ZN5jlcxx14ModuleRegistry13create_moduleEP12_jl_module_t at /home/travis/.julia/packages/CxxWrap/lDNAy/deps/usr/lib/libcxxwrap_julia.so (unknown line)
register_julia_module at /home/travis/.julia/packages/CxxWrap/lDNAy/deps/usr/lib/libcxxwrap_julia.so (unknown line)
register_julia_module at /home/travis/.julia/packages/CxxWrap/lDNAy/src/CxxWrap.jl:360 [inlined]
readmodule at /home/travis/.julia/packages/CxxWrap/lDNAy/src/CxxWrap.jl:664
wrapmodule at /home/travis/.julia/packages/CxxWrap/lDNAy/src/CxxWrap.jl:670
unknown function (ip: 0x7f61c8c98050)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2158 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1692 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:369
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:458
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:409 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:817
jl_interpret_toplevel_thunk at /buildworker/worker/package_linux64/build/src/interpreter.c:911
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:814
jl_eval_module_expr at /buildworker/worker/package_linux64/build/src/toplevel.c:181
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:640
jl_parse_eval_all at /buildworker/worker/package_linux64/build/src/ast.c:872
jl_load at /buildworker/worker/package_linux64/build/src/toplevel.c:872
include at ./Base.jl:377
include at /home/travis/.julia/packages/CxxWrap/lDNAy/src/CxxWrap.jl:1
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2158 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1692 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:369
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:458
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:409 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:817
jl_interpret_toplevel_thunk at /buildworker/worker/package_linux64/build/src/interpreter.c:911
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:814
jl_eval_module_expr at /buildworker/worker/package_linux64/build/src/toplevel.c:181
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:640
jl_parse_eval_all at /buildworker/worker/package_linux64/build/src/ast.c:872
jl_load at /buildworker/worker/package_linux64/build/src/toplevel.c:872
include at ./Base.jl:377
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2144 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1692 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:369
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:458
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:409 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:817
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:744
jl_interpret_toplevel_thunk at /buildworker/worker/package_linux64/build/src/interpreter.c:911
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:814
jl_toplevel_eval_in at /buildworker/worker/package_linux64/build/src/toplevel.c:843
eval at ./boot.jl:331 [inlined]
eval at ./client.jl:449
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2144 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
top-level scope at ./none:3
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:808
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:764
jl_toplevel_eval_in at /buildworker/worker/package_linux64/build/src/toplevel.c:843
eval at ./boot.jl:331
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2144 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
exec_options at ./client.jl:264
_start at ./client.jl:484
jfptr__start_2076.clone_1 at /home/travis/julia/lib/julia/sys.so (unknown line)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2144 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2322
jl_apply at /buildworker/worker/package_linux64/build/ui/../src/julia.h:1692 [inlined]
true_main at /buildworker/worker/package_linux64/build/ui/repl.c:96
main at /buildworker/worker/package_linux64/build/ui/repl.c:217
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_start at /home/travis/julia/bin/julia (unknown line)
Allocations: 6820435 (Pool: 6818781; Big: 1654); GC: 5
ERROR: LoadError: Failed to precompile CxxWrap [1f15a43c-97ca-5a2a-ae31-89f07a497df4] to /home/travis/.julia/compiled/v1.4/CxxWrap/WGIJU_AN9Mx.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1272
 [3] _require(::Base.PkgId) at ./loading.jl:1029
 [4] require(::Base.PkgId) at ./loading.jl:927
 [5] require(::Module, ::Symbol) at ./loading.jl:922
 [6] include(::String) at ./client.jl:439
 [7] top-level scope at none:5
in expression starting at /home/travis/build/oscar-system/Polymake.jl/deps/build.jl:1
┌ Error: Error building `Polymake`: 
└ @ Pkg.Operations /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Pkg/src/Operations.jl:892

@benlorenz benlorenz merged commit dc5d052 into master Mar 9, 2020
@saschatimme saschatimme deleted the enh/gcc_version_check branch March 9, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschatimme saschatimme saschatimme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlorenz @saschatimme