Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper expressify for n_transExt #394

Merged
merged 1 commit into from
Mar 20, 2021
Merged

proper expressify for n_transExt #394

merged 1 commit into from
Mar 20, 2021

Conversation

tthsqe12
Copy link
Contributor

fixes a todo in the code and the following bad behavior:

julia> dump(Singular.AbstractAlgebra.expressify(FunctionField(QQ, ["a", "b", "c"])[1](BigInt(3)^80)))
Expr
  head: Symbol macrocall
  args: Array{Any}((3,))
    1: GlobalRef
      mod: Module Core
      name: Symbol @int128_str
    2: Nothing nothing
    3: String "147808829414345923316083210206383297601"

fingolfin
fingolfin approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@thofma thofma merged commit 6b922bd into oscar-system:master Mar 20, 2021
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
@tthsqe12
proper expressify for n_transExt (oscar-system#394)
a206a20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthsqe12 @fingolfin @thofma