Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sidebar colors #3

Merged
merged 9 commits into from
Mar 25, 2020
Merged

fix sidebar colors #3

merged 9 commits into from
Mar 25, 2020

Conversation

t7yang
Copy link
Contributor

@t7yang t7yang commented Mar 25, 2020

  • I roll back most of the colors, due I found my modified break the theme.
  • add json schema
  • add launch.json for better dev experience
  • extract colors part make it share between normal and italic.

@oscarmcm oscarmcm self-requested a review March 25, 2020 15:19
@oscarmcm oscarmcm self-assigned this Mar 25, 2020
@oscarmcm oscarmcm added the enhancement New feature or request label Mar 25, 2020
@oscarmcm
Copy link
Owner

Awesome!! Thanks for the update looks much better 👍

@oscarmcm oscarmcm merged commit c1f0c06 into oscarmcm:master Mar 25, 2020
@t7yang
Copy link
Contributor Author

t7yang commented Mar 25, 2020

2018 to 2020, still one of my favorite theme.

@oscarmcm
Copy link
Owner

Thanks, really appreciate the kind comments 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarmcm oscarmcm Awaiting requested review from oscarmcm

Assignees

@oscarmcm oscarmcm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t7yang @oscarmcm