added support for getenv() local_only parameter

[frugan-dev]

added support for getenv() local_only parameter to return the value of locally-set environment variables

[oscarotero]

Hi.
Thanks for this. My only concern is this is a breaking change so I'd add this feature as an option. For example:

Env::$options |= Env::LOCAL_ONLY;

[oscarotero]

Sorry again. The first getenv can return something evaluated as false (like 0, "", etc). We need to check if the returned value is strictly false. In other words:

$value = getenv($name, true);

if ($value === false) {
    $value = getenv($name);
}

[oscarotero]

One doubt comes to my head: We check whether a value exists only in local, and if not, returns the value from global. Does it make sense? It's the same than not cheking at all, isn't? Could you make a test with both cases?

[frugan-dev]

From what i read in the PHP documentation https://www.php.net/manual/en/function.getenv.php, in some environments (PHP running in a SAPI such as Fast CGI), getenv() function without $local_only parameter will always return the value of an environment variable set by the SAPI.

So if you change a variable with putenv(), env() function does not return the modified value.

For example:

// global value
echo getenv('DOCUMENT_ROOT');
// /home/user/public

// always return local value, NOT global value
echo getenv('DOCUMENT_ROOT', true);
//

putenv('DOCUMENT_ROOT=/tmp');

// always return global value, NOT local value
echo getenv('DOCUMENT_ROOT');
// /home/user/public

// local value
echo getenv('DOCUMENT_ROOT', true);
// /tmp
 

With your repo:

Env::init();

echo env('DOCUMENT_ROOT');
// /home/user/public

putenv('DOCUMENT_ROOT=/tmp');

// always return global value, NOT local value
echo env('DOCUMENT_ROOT');
// /home/user/public

With new env() function:

function env($name)
{
    if (Env::$options & Env::USE_ENV_ARRAY) {
        $value = isset($_ENV[$name]) ? $_ENV[$name] : false;
    } elseif (($value = getenv($name, true)) === false) {
        $value = getenv($name);
    }

    if ($value === false) {
        return Env::$default;
    }

    return Env::convert($value);
}

echo env('DOCUMENT_ROOT');
// /home/user/public

putenv('DOCUMENT_ROOT=/tmp');

echo env('DOCUMENT_ROOT');
// /tmp

[oscarotero]

Ok, thanks for your detailed explanation!

[oscarotero]

Merged. I'll release a new version soon.
Thanks for your contribution!

[frugan-dev]

Thank you! I think your observation is correct, and it would be better to change the code as you say:

$value = getenv($name, true);

if ($value === false) {
    $value = getenv($name);
}

[oscarotero]

Yes, I just did it.