Revert linked lists #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld need to find proper way of navigating them, maybe use std::list and pointers to access elements?
…nked lists to deploy in time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the vector structures that were used (e.g. for orbits, separatrices, singularities...) are reverted to pointer linked lists for ease of implementation.
The main reason is that P4 keeps track of the "current X" (separatrice, singularity, etc) being used in computations, with a pointer to that struct. Using vectors we needed an iterator or an index, but this made it impossible to keep track of exactly which container we were iterating in (which vector does this iterator belong to?, what if we're trying to get an iterator from an empty vector?, etc.).