[feature suggestion] deactivating of items in user panel

[trains58554]

Hi

I have made some changes to hDefines and item.php in the rood directory to add the functionality of letting the user deactivate their items. I though I would share this code with you and let you guys decide if you want to add it to the core.

This code I added to the hDefines.php file

/**
     * Gets url for deactivating an item
     *
     * @param int $id
     * @return string
     */
    function osc_item_deactivate_url($id = '') {
        if ($id == '') $id = osc_item_id();
        if ( osc_rewrite_enabled() ) {
            return osc_base_url() . 'item/deactivate/' . $id ;
        } else {
            return osc_base_url(true) . '?page=item&action=deactivate&id=' . $id  ;
        }
    }

item.php in root directory changes added at line 245

case 'deactivate':
                    $secret = Params::getParam('secret');
                    $id     = Params::getParam('id');
                    $item   = $this->itemManager->listWhere("i.pk_i_id = '%s' AND ((i.s_secret = '%s') OR (i.fk_i_user_id = '%d'))", $id, $secret, $this->userId);
                    View::newInstance()->_exportVariableToView('item', $item[0]);
                    if ($item[0]['b_active']==1) {
                        // DEACTIVETE ITEM
                        $mItems = new ItemActions(false) ;
                        $success = $mItems->deactivate( $item[0]['pk_i_id']);

                        if( $success ){
                            osc_add_flash_ok_message( _m('The item has been deactivated') ) ;
                        }else{
                            osc_add_flash_error_message( _m('The item can\'t be deactivated') ) ;
                        }
                    }else{
                        osc_add_flash_error_message( _m('The item has already been deactivated') );
                    }

                    $this->redirectTo( osc_user_list_items_url( ) );
                break;

Lastly the change in theme user-items.php

<?php if(osc_item_is_active()) {?>
                                            <span>|</span>
                                            <a href="<?php echo osc_item_deactivate_url();?>" ><?php _e('Deactivate', 'modern'); ?></a>
                                            <?php } ?>

One more addition to make this work with permalinks
in generate_rules.php add the following code at line 53

$rewrite->addRule('^item/deactivate/([0-9]+)/?$', 'index.php?page=item&action=deactivate&id=$1');

Thanks

Jay

[trains58554]

Hi

I just thought of another suggestion that goes along with this. With the user having the ability to disable their items there potentially could become a large amount of ads that are not active so I was thinking there could be a cron job that would check every 30 days or what ever the admin wants and clean out the deactivated ads.

Jay

[conejoninja]

Hi Jay,

What is the goal of deactivating items?

[trains58554]

The goal I see with deactivating the items is if the seller sells an item and takes the ad down but then the buyer backs out the user can just re activate the ad instead of having to repost it.

Jay

[TurbineJesse]

I think this can be a very useful function as well. It allows you to put an ad "on-hold", which can be great if you're selling an item and have someone who says they'll buy it. You can "deactivate" it, removing it from view on the main site. If that person doesn't show up or backs-out of buying your item, you can just activate the ad without having to delete the ad and post it again (which isn't a good option if you're charging for ads).

If nothing else, it would be nice for this function to at least exist within the core files, allowing people to choose to use it or not. Beats having to edit the core files on every update! :-) More functions = more tools available to developers.

[trains58554]

I got to thinking that the redirect to link should use the $_SERVER['HTTP_REFERER'] instead of just redirecting to the users item list that way if they are on say page 4 it will take them back to page 4.

Jay

[conejoninja]

You're right, we should start using more http_referer

[conejoninja]

We need to discuss how to implement this feature, It could end up with hundreds of dead ads (deactivated).
I clear the milestone and push it for next version since it's not time sensitive

[trains58554]

I never thought about that. I guess there always could be an option in the admin side where can select ads that have been deactivated for x days will be deleted and he could have a perge button as well. Just an idea.

[larsreineke]

It seems the file structure has been altered in the meantime, hasn't it? At least I can't find any item.php in the root directory. Can you point me to a solution with v3.3.2?

[larsreineke]

Ah, nevermind, found it: It's in oc-includes/osclass/controller/item.php now.

[quickhat]

Great work I just found this and would be really grateful if you could explain how to make it work with osclass 3.4.1

[mappo1980]

hi, I have version 3.5 you tell me how can I do?

[aide2001]

ive found this to be great, but would like to implement this when someone uses my paypal buy it now button and they get referred back to the site and then the item is deactivated.
So far the paypal thing works, they get redirected to a page i set up, now all i need is the code to help deactivate the item, if you could help.
I have thought it would be say www.website.co.uk/page/success?item/deactivate/itemnumber but doesnt work at all