Add discord bot #45
Merged
Add discord bot #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2020 21:09
daemon1024
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Thanks for the awesome work on this @Arnav-Khare . I have requested some changes. Please go through it once 😄
Comment on lines
+115
to
+118
| if(message.content === '!instagram') | ||
| { | ||
| message.channel.send('https://tenor.com/view/dont-do-that-avengers-black-panther-we-dont-do-that-here-gif-12042935') | ||
| } |
sidntrivedi012
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Some small changes. Other than that, good work @Arnav-Khare . Thanks for the discord bot.
Comment on lines
+115
to
+118
| if(message.content === '!instagram') | ||
| { | ||
| message.channel.send('https://tenor.com/view/dont-do-that-avengers-black-panther-we-dont-do-that-here-gif-12042935') | ||
| } |
|
@Arnav-Khare any update on the changes? Feel free to ask if you need any help in implementing the changes. 🙂 |
Arnav-Khare
commented
Oct 25, 2020
There was a problem hiding this comment.
I had implemented the required changes...can you please review it.. @daemon1024 @sidntrivedi012 ...and sorry for the delay.
sidntrivedi012
approved these changes
Oct 25, 2020
| { | ||
| let comicNo = Math.floor(Math.random() * (2000 - 100 + 1) + 100) | ||
|
|
||
| axios.get(`http://xkcd.com/${comicNo}/info.0.json`).then(resp => { |
There was a problem hiding this comment.
Its really better to use axios 👍
daemon1024
approved these changes
Oct 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #55