Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for warnings and perhaps a bug #4

Closed
proj4-bot opened this issue May 22, 2015 · 1 comment · Fixed by #280
Closed

Patch for warnings and perhaps a bug #4

proj4-bot opened this issue May 22, 2015 · 1 comment · Fixed by #280

Comments

@proj4-bot
Copy link

Reported by dcthomp on 3 Jun 2008 15:19 UTC
I've made some changes to PROJ.4 to get it compiling without
any warnings even setting CFLAGS="-W -Wall". I've attached a
patch.

Most of the changes are straightforward, a few are tedious, and
one of the warnings appears to actually point to a bug. Specifically,
in src/PJ_imw_p.c it looks like the argument "double* yc" is
shadowed by a local variable below and thus never used. The patch
includes what I believe to be a fix, but it would be nice if someone
reviewed it.

The only other real problem I had was with the declaration and
initialization of "static char EMESS_H_ID[]" inside src/emess.h.
Since this header file is included multiple times it results in
EMESS_H_ID being instantiated in multiple object files. I removed
the variable since it doesn't appear to be used.

Migrated-From: https://trac.osgeo.org/proj/ticket/4

@proj4-bot
Copy link
Author

Attachment added by dcthomp on 3 Jun 2008 15:21 UTC
https://trac.osgeo.org/proj/attachment/ticket/4/proj4-warnings.patch

busstoptaktik added a commit that referenced this issue May 19, 2016
Projections starting with d, e and f converted to new style
ccrook pushed a commit to ccrook/PROJ that referenced this issue Apr 28, 2020
Fixes reverse step and range errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant