Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change network dependence on configure / build time #4219

Closed
mwtoews opened this issue Aug 11, 2024 · 0 comments · Fixed by #4220
Closed

Change network dependence on configure / build time #4219

mwtoews opened this issue Aug 11, 2024 · 0 comments · Fixed by #4220
Assignees
Labels
Milestone

Comments

@mwtoews
Copy link
Member

mwtoews commented Aug 11, 2024

This item is to address some points raised by @gdt starting in this mail list thread, around "it's a bug to try to use the network at build time".

I have some work-in-progress to address this item (thus I'm assigned), which I hope to put out very soon, as I'm aware there could be a RC in the coming week.

My proposed solution is to have a CMake option USE_NETWORK with default OFF. It will show warnings if test dependencies cannot be met, and run a subset of tests that can still run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant