Javascript - Extracting Message Formatter interface #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 13, 2019 18:39
…n message formatter or change output piping style.
…e logging in javascript would want to pass an object reference to the logger rather than a string.
|
Thanks for your contribution! |
|
I added it in 1.6.24. |
Merged
1 task
1 task
This was referenced Nov 26, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So mostly this is freehand refactoring (it'd be nice to add a test suite to the JS side here). But additionally, there are two new JS configurable variables at the root, such that someone using the library can modify or replace the message formatting.
I quick put this together because I was adding some logging to an app I've been converting to Kotlin-Js, and couldn't quite get it to produce JSON log lines rather than traditional ones. 🤷🏻♂️