Moved to new MPP format, kotlin dsl #81
Conversation
|
Thanks! I will review it as soon as I have some time. |
| compilations.named("main") { | ||
| kotlinOptions { | ||
| metaInfo = true | ||
| sourceMap = true |
There was a problem hiding this comment.
I removed outputFile, but the result js jar seems the same
| kotlin("multiplatform") version "1.3.41" | ||
| id("com.jfrog.bintray") version "1.8.4" | ||
| `maven-publish` | ||
| `java-library` //todo: ask whether we need javadoc at all as it is always empty |
There was a problem hiding this comment.
Do you need javadocs? The jars are empty
There was a problem hiding this comment.
If you check this you'll see jars are not empty: https://repo1.maven.org/maven2/io/github/microutils/kotlin-logging/1.6.26/
It is required by maven central
There was a problem hiding this comment.
I think dokka would help
There was a problem hiding this comment.
Sorry, by empty I meant jar contains only MANIFEST.MF
There was a problem hiding this comment.
But there are no javadocs themselves
|
Thanks, it looks good! |
|
I released version 1.7.0-mpp, will test it and then merge. you're welcome to check also. |
|
It looks good, I merged it. Thanks again! |
This PR is for issue #64
As there is a discussion about Kotlin DSL in this issue, I've added it too(upgrading Gradle to 5.5.1 and Kotlin to 1.3.41)
Compatibility version of Kotlin in
kotlin-logging-jvmI kept 1.1. Tried not to change an existing codebase to make easier to review the PR. It seems I fixed all backward-incompatible stuff, but review though, please.