Add poolMaxIdleTime configuration option to TCP appenders #49
Conversation
|
Regarding the failed quality check, I followed the convention already used in AbstractPooledObject. There is no way to explicitly specify package-private access. I can either change these to |
There was a problem hiding this comment.
Thank you very much for this contribution! I think it is a very reasonable addition to this library. Regarding the failed quality check – you can safely ignore it as I was just playing with Codacy a bit and its configuration does not match the checkstyle/spotbugs rules within this project. I added a few comments that I'd like to ask you to change in order I can merge this PR.
src/main/java/de/siegmar/logbackgelf/pool/SimpleObjectPool.java
Outdated
Show resolved
Hide resolved
src/main/java/de/siegmar/logbackgelf/pool/SimpleObjectPool.java
Outdated
Show resolved
Hide resolved
joelittlejohn
force-pushed
the
add-max-idle-time
branch
from
5b4168d
to
0779a34
Compare
|
Hi @osiegmar, thanks for looking at this! I've force pushed to update my branch as per your review comments. If you want to see the exact changes I made, they're here: https://github.com/joelittlejohn/logback-gelf/compare/5b4168d..0779a34 |
When connections remain open without being used, they may be considered stale by the server and closed. This can lead to log messages failing with java.lang.SocketException: broken pipe This commit introduces a maximum 'idle time' for pooled connections. If a connection has not been used within that time, it will be considered stale and not reused. By default, this new feature is disabled.
joelittlejohn
force-pushed
the
add-max-idle-time
branch
from
0779a34
to
63b08cd
Compare
|
Thanks a lot! |
|
BTW what value (time interval) have you used for getting rid of your problem? Have you disabled |
|
We found that our connections were considered stale after somewhere between 15 to 20 seconds of idle time, so to be on the safe side we're using a max idle time of 10 seconds. We're still using |
When connections remain open without being used, they may be
considered stale by the server and closed. This can lead to log messages
failing with
java.lang.SocketException: broken pipe
This commit introduces a maximum 'idle time' for pooled connections. If
a connection has not been used within that time, it will be considered
stale and not reused. By default, this new feature is disabled.
I'm interested to hear your thoughts on this PR, and happy to make changes and adjustments if you need me to. We have been experiencing a bug where many of our log messages failed to arrive in graylog and tracked the problem down to the server ELB max idle time. This PR is intended to help us recycle connections if they have not been used recently, but to avoid recycling them if they have been used recently.