Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Styling into CSS files to make components more reusable #35

Open
1 task
Nikolaa92 opened this issue Jun 7, 2024 · 0 comments
Open
1 task

Move Styling into CSS files to make components more reusable #35

Nikolaa92 opened this issue Jun 7, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Nikolaa92
Copy link
Contributor

Problem

Some files including Navbar.tsx, LogoutButton.tsx, DashboardPage.tsx, Chart.tsx and Homepage.tsx have styling done from inside of the component.

Solution

It would be the best practice to take out styling code and move it to CSS styling files instead in order to modularize components.

Additional information

Homepage.tsx is using combination of React and DOM manipulation to style. It would be best practice to convert actual DOM manipulation into React Virtual DOM manipulation.

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to implement this feature!
@Nikolaa92 Nikolaa92 added the enhancement New feature or request label Jun 7, 2024
@b-the-coder b-the-coder added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants