Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XTerm auto fit add-on not auto-adjusting to parent container #32

Open
crumblepie opened this issue Feb 18, 2022 · 0 comments
Open

XTerm auto fit add-on not auto-adjusting to parent container #32

crumblepie opened this issue Feb 18, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@crumblepie
Copy link
Collaborator

Context (current result)

Currently the size of the xterm terminal is hardcoded in TerminalView.jsx. This means the terminal is not resizing to the parent container (the active tab content container).

Expected result

XTerm resizes when the user resizes the main window.

Process to reproduce

  1. Comment out the maxWidth and maxHeight properties for the main BrowserWindow on around lines 59 and 60 of main.jsx.
  2. npm run start and switch to the Terminal tab
  3. Try resizing the main window and the terminal will stay constant size

Screenshots

Screen Shot 2022-02-18 at 10 48 19 am

Possible Fix

Some suggestions of possible places to start:

  • Terminal.css file
  • Issues in Xterm's issues list relating to xterm-addon-fit
@crumblepie crumblepie added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant