Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substation quest suggests to add reference as a name, creating osmose issues #1786

Closed
Jibec opened this issue Mar 14, 2023 · 8 comments
Closed

Comments

@Jibec
Copy link
Contributor

Jibec commented Mar 14, 2023

I applied this kind of substation quests:
image

but I notice it triggers a new issue:
image

what is this number? a reference?
if my understanding is correct, related source code is https://github.com/osm-fr/osmose-backend/blob/master/analysers/analyser_merge_power_substation_minor_FR.py#L64 is it correct?
If so, maybe simply check with fields["Nom poste"].isdigit() is False?

@frodrigo
Copy link
Member

This data source compile other sources. Look like at some point a reference is put into the name field for Stransbourg. There is also alpha-num ref for Stransbourg.

@Jibec
Copy link
Contributor Author

Jibec commented Mar 14, 2023

When I look at the data, I see:

2023-03-14 21:15:20,484 - In the source, there 27370 unique values
2023-03-14 21:15:20,514 - ..including 27370 strings
2023-03-14 21:15:20,515 - ...including 6121 digits

used code:

df_es = pd.read_csv(SOURCE, sep=";", usecols=[NOM_COL], low_memory=False)
df_es.fillna("", inplace=True)
s = df_es[NOM_COL]
s_strings = s[s.apply(lambda x: isinstance(x, str))]
s_digits = s[s.apply(lambda x: str.isdigit(x))]
s_non_digits = s[~s.apply(lambda x: str.isdigit(x))]

@frodrigo
Copy link
Member

frodrigo commented Aug 5, 2023

@flacombe what do you think of this ?

@flacombe
Copy link
Contributor

flacombe commented Aug 7, 2023

Hello

Look like at some point a reference is put into the name field for Stransbourg.

I think you are right.
From the very beginning of this agregation, I recommended separating name and ref, like on OSM.
Currently, only names are part of the file so when you don't have name, you put ref instead and here the fun begins.

The analyzer could be modified by operator lookup: when Strasbourg Electricite Réseau, it's ref and name instead.
I could done it next week.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Aug 7, 2023
@frodrigo
Copy link
Member

frodrigo commented Aug 7, 2023

Done in #1981.

@Jibec
Copy link
Contributor Author

Jibec commented Aug 7, 2023 via email

@flacombe
Copy link
Contributor

flacombe commented Aug 8, 2023

So quick!
Thank you

@frodrigo
Copy link
Member

frodrigo commented Aug 8, 2023

We just got it in 5 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants