-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive lamp post with waste bin #2243
Comments
Shouldn't this be For instance, add colour=yellow, and tell me if this is the color of the bin or the lamp post. On the other hand, bin=yes only says there's a bin around, not that the lamp post "is" also the bin. |
To me it doesn't make sense that we have two different systems like this. Given that From what I gathered, for 99% of all items they will be tagged as Even if you were to add Wonder if this is just a case for a proposal, the whole situation irks me 🤔 |
I recommend mapping the street lamps and waste bins as separate nodes. You can give the waste bins a |
I would also tag it as 2 separate nodes (amenity=waste_basket with support=street_lamp). On a street lamp, also other things can be attached, for example guideposts (tourism=information, information=guidepost), emergency access points (highway=emergency_access_point or emergency=access_point), excrement_bags (vending=excrement_bags), .... And I already saw 3 or 4 different things attached to a street lamp ... Therefore, mapping as separate nodes is probably the only sensible option, even if this results in confusing "node stacks". Unfortunately, OpenStreetMap lacks a really good tagging concept for such "multiple features" in one place. |
As fixing the "multiple features" issue of OSM is a bit out of the scope of Osmose I suspect this issue can be closed until OSM itself has found a solution? |
I also think this could be closed ... Only one thought: I don't know the exact text of the warning, sometimes the wording makes a difference (and a nicely worded advice that it is usually better to tag different features separately might be helpful). |
At this moment, the warning message is:
with the description in the side column:
We could maybe rephrase the latter to:
(Suggestions welcome. Note that the same analyser also warns for things you really won't find together, like a waterway and an aeroway) |
I think that would work, if it's unintended you would still be able to look at it and see what's wrong. 100% for rephrasing the message |
Also 100% for rephrasing. Better wording can make a difference. The text is fine I think and a good improvement. Another variant could be (but I am not a native English speaker) This object has two tags that represent different features. According to the principle of “one feature, one OSM element”, these should better be mapped as two separate objects. And not sure if something like this should be added: (Even if it is exactly the same position and seems to be clear which tags belong to which feature.) Because that is probably the decision problem that has led many mappers (including me) to double tagging. In addition, the principle “One feature, one OSM element” is not a really easy principle (only see the looooong text of the Wiki page). Some other thoughts, maybe a little off-topic (but connected): For me still a little confusing (after many years of mapping):
I just want to point out that conflicting Osmosis warnings can occur, which is frustrating (and confusing) and no clear solution is provided. But again, it can be a reason for double tagging, because from a human perspective it is very often clear which tags belong to which feature (not always, of course), and double tagging seems to be the easiest way to go. But a first step could be a rephrasing here ... |
See #2243 (comment) and following comments
I agree it's a pretty complicated topic with many difficult/debatable cases. |
See #2243 (comment) and following comments
The updated text is live. (Translations will follow later, that's a manual synchronization) |
osmose needs to be more refined when a node has
amenity=waste_basket
andhighway=street_lamp
It's fairly used all around and you see waste baskets attach to street lamps all over the place
The error Osmose reports is that it's unsual to use
amenity=
andhighway=
togetherThe text was updated successfully, but these errors were encountered: