Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn lanes are shown as through lanes in lane overview #12481

Closed
Zero3 opened this issue Aug 15, 2021 · 13 comments · Fixed by #12731
Closed

Turn lanes are shown as through lanes in lane overview #12481

Zero3 opened this issue Aug 15, 2021 · 13 comments · Fixed by #12731
Assignees
Labels
Milestone

Comments

@Zero3
Copy link

Zero3 commented Aug 15, 2021

Description

OsmAnd does not always show the correct lanes in the lane overview.

In the example shown below, when driving on the road from north west to south east, the road is splitting into two left turn lanes and two through lanes before the junction at the bottom of the picture:

image

(OSM link: https://www.openstreetmap.org/edit?editor=id#map=18/55.37221/10.44506)

The two left lanes are mapped as a single way in OSM with lanes=2 and turn=left. The two through lanes are mapped as a single way with lanes=2. This looks correct to me, but as seen below, OsmAnd shows 4 through lanes instead:

Screenshot_20210814-163456

On a side note, the "turn slightly right" instruction (see top-left corner of the screen) seems wrong as well, given that I was to drive straight ahead.

Your Environment

OsmAnd Version: 4.0.5
Android/iOS version: 10

Maps used (online or offline): Online

@vshcherb
Copy link
Member

I think the lanes are displayed correctly i.e. 4 lanes 2 + 2. Of course it is possible to improve how it's rendered with turn:lanes tag but even without it, it looks ok.

This particular junction has a problem that https://www.openstreetmap.org/way/25356914 (cause it's a link) should not be part of any announcement and that's what could be improved potentially.

@vshcherb
Copy link
Member

vshcherb commented Aug 15, 2021

@sonora The issue was introduced here or ealier
99f8f38
22a1548
I suspect we need to delete code

// sometimes links are
		if ((current <= rs.leftLanes + rs.rightLanes) && (rs.leftLanes > 1 || rs.rightLanes > 1)) {
			rs.speak = true;
		}

and double check what was mentionned in #2571

@vshcherb vshcherb added this to the 4.1-backend milestone Aug 15, 2021
@Zero3
Copy link
Author

Zero3 commented Aug 15, 2021

@vshcherb thanks for getting back :)

I think the lanes are displayed correctly i.e. 4 lanes 2 + 2. Of course it is possible to improve how it's rendered with turn:lanes tag but even without it, it looks ok.

I agree that 4 lanes is a correct number to show. The issue is that they all show as "go straight", even though the two to the left should be shown as "turn left". I have seen OsmAnd show turn lanes correctly, so it seems like a bug that it does not do so in this case?

This particular junction has a problem that https://www.openstreetmap.org/way/25356914 (cause it's a link) should not be part of any announcement and that's what could be improved potentially.

Just to understand correctly: When you say "announcement", do you mean the instruction at the top-left of the screen? I.e. the "turn slightly right" arrow? If so, I agree :).

(I do not recall if there was a voice announcement at this point or not.)

@vshcherb
Copy link
Member

Yes, in most of situations these alerts should not appear if you go straight, though they could appear if the roads are the same priority. Here it's not the case (secondary_link vs secondary), so the fix is easy but it needs to be double checked and aligned with other issues.

@Zero3
Copy link
Author

Zero3 commented Aug 30, 2021

@sonora let me know if I can assist you with any data or testing or something. I can also drive to the place mentioned and test any fix you might have.

@Zero3
Copy link
Author

Zero3 commented Aug 31, 2021

Besides the "secondary_link vs secondary" announcement bug that @vshcherb mentions above, i have a suspicion about the cause of the original issue. Given my example above:

  • When tagged as turn:lanes=left|left, OsmAnd seems to show the turn lanes correctly.
  • When tagged as turn=left, OsmAnd seems to ignore the tag and treat the lanes as through.

Both variations are documented on https://wiki.openstreetmap.org/wiki/Key:turn#Current_usage

@Zero3
Copy link
Author

Zero3 commented Sep 16, 2021

@Dima-1 @vshcherb It seems like you guys fixed the announcement bug, but what about the original issue? Which seems to be that the turn tag is ignored and only the turn:lanes tag is working (see above: #12481 (comment))

@vshcherb
Copy link
Member

Nothing to fix, "turn:lanes" is a supported mechanism to clarify turn lanes on the road

@Zero3
Copy link
Author

Zero3 commented Sep 16, 2021

@vshcherb Do you mean that you only intend to support the turn:lanes tag, and not the turn tag? These are both used in the OSM data, and are documented accordingly at https://wiki.openstreetmap.org/wiki/Key:turn#Current_usage:

When turns apply similarly to all lanes in the same direction (or when there's a single lane per direction):

  • turn=*
  • turn:forward=*
  • turn:backward=*
  • turn:both_ways=*

To specify different turn indications for each lane when there are multiple lanes in the same direction (see below):

  • turn:lanes=*
  • turn:lanes:forward=*
  • turn:lanes:backward=*
  • turn:lanes:both_ways=*

@vshcherb
Copy link
Member

turn=* is not supported

@Zero3
Copy link
Author

Zero3 commented Sep 16, 2021

@vshcherb Thanks for the response. What I am trying to understand is whether it is intentional that OsmAnd does not support turn=*. If not, and it is just something that has not been implemented yet, I could create a feature request for it. But I do not want to do that if there is some kind of good reason not to support the tag.

@vshcherb
Copy link
Member

Well, it's simple we have limited capacity and priorities.
Usually tags with less than 10 000 capacity not considered to be implemented at all only some exceptions. And another thing that the tail of features is always truncated that we can complete prioritized tasks for a next half-year and a year.

So there is nothing wrong to create a feature request and if it get's closed you could remind in a year or 2. I think the development capacity is the biggest factor here. So I would say today you should probably not create request for turn support comparing to already created issues.

@Zero3
Copy link
Author

Zero3 commented Sep 20, 2021

@vshcherb thanks for the explanation 👍. Makes sense. I will not create a feature request now then, but adapt my mapping habbits to always use turn:lanes, even where a turn tag would have been sufficient.

I updated the mentioned OSM wiki page with this information (diff), so that other mappers can be aware of this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants