Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add search menu, fix urls #446

Merged
merged 65 commits into from
Aug 20, 2024
Merged

add search menu, fix urls #446

merged 65 commits into from
Aug 20, 2024

Conversation

alisa911
Copy link
Contributor

No description provided.

@alisa911 alisa911 marked this pull request as draft July 29, 2024 14:31
@alisa911
Copy link
Contributor Author

#432

@alisa911 alisa911 mentioned this pull request Aug 1, 2024
Closed
10 tasks
@alisa911 alisa911 marked this pull request as ready for review August 12, 2024 04:32
@alisa911 alisa911 requested a review from RZR-UA August 12, 2024 04:32
RZR-UA
RZR-UA requested changes Aug 12, 2024
View reviewed changes
map/src/App.js Outdated Show resolved Hide resolved
map/src/context/AppContext.js Show resolved Hide resolved
map/src/infoblock/components/favorite/AddFavoriteDialog.jsx Outdated Show resolved Hide resolved
map/src/infoblock/components/wpt/WptTagsProvider.js Outdated Show resolved Hide resolved
map/src/manager/PoiManager.js Show resolved Hide resolved
map/src/menu/search/search/SearchResults.jsx Show resolved Hide resolved
map/src/map/layers/SearchLayer.js Outdated Show resolved Hide resolved
map/src/map/layers/SearchLayer.js Outdated Show resolved Hide resolved
map/src/map/layers/SearchLayer.js Show resolved Hide resolved
map/src/map/layers/SearchLayer.js Outdated Show resolved Hide resolved
@RZR-UA
Copy link
Contributor

RZR-UA commented Aug 15, 2024 •
edited by alisa911
Loading

  • when nothing is found (search-poi returned null), the progress spinner never stops

@alisa911 alisa911 requested a review from RZR-UA August 16, 2024 09:56
@alisa911
Copy link
Contributor Author

#447

@alisa911 alisa911 merged commit 0a54ef8 into main Aug 20, 2024
@alisa911 alisa911 deleted the task432 branch August 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RZR-UA RZR-UA RZR-UA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisa911 @RZR-UA