MapController.setCenter offset

[devemux86]

When we call the new MapController.setCenter implemented at revision 423680b,
the map center is not at the GeoPoint we pass, but at an offset of half the screen down right.
Can you confirm that?

[kurtzmarc]

I tried triggering it in OpenStreetMapViewer via a menu item and both setCenter() and animateTo() worked properly. However if it is called from onActivityCreated() there is an issue. I think it's because the MapView's width and height is zero because it hasn't had onLayout called yet. Is that where you are calling setCenter()? Or can you confirm that when you call it mMapView.getWidth() is zero?

[devemux86]

You are right, now there is need to check the map view size.
If map view has been layout then setCenter works correctly.

[devemux86]

Sorry for the close / reopen, you can close the issue.

[kurtzmarc]

I think I want to keep this open a little longer until I investigate the getWidth() issues and see if there is a nice solution for that.

[lcacheux]

I had this issue in my application which was previously using OSMDroid 4.1 and called setCenter in Fragment.onCreateView. To make it work properly with 4.2, I used something like this in onCreateView :

ViewTreeObserver vto = view.getViewTreeObserver();
vto.addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
    @Override
    public void onGlobalLayout() {
        mMapView.getController().setCenter(...);
    }
});

This way, setCenter is called only once the layout has been drawn and width/height has been calculated.

[ritschwumm]

i found another workaround which might be a little bit less invasive:

just delay the call to setCenter by one tick in the main loop so android gets a chance to do it's layouting before the actual call happens.

new Handler(Looper.getMainLooper()).post(
    new Runnable() {
        public void run() {
            mapController.setCenter(...);
        }
    }
);

thinking about a proper solution, would it make sense to make center the one property of a MapView which is used to calculate everything else from?

[devemux86]

I use externally the way with the OnGlobalLayoutListener.

But I like also the way Mapbox handle this issue internally.
At MapView.onSizeChanged they call MapController.mapViewLayedOut
where it executes any actions that have been recorded before map view is layed out.

[ziem]

Any progress?

[kjeremy]

I'm seeing this too.

[kurtzmarc]

Please try out this patch and let me know if it works:
https://gist.github.com/kurtzmarc/f99b0bbbff46791d2168

[Sash0k]

Please try out this patch and let me know if it works

Unfortunately, it works incorrect.

    GeoPoint defaultPoint = new GeoPoint(Const.DEF_LATITUDE, Const.DEF_LONGITURE);
    mMapView.getController().animateTo(defaultPoint);

In my project this code set defaultPoint in center screen before osmdroid 4.2. Now it set point at pixel (0,0) without patch and at pixel (screen.w, screen.h) with one.

[kurtzmarc]

Sorry - I missed that method. I am going to commit a different approach that will keep track of the calls you make and "replay" them in order once the MapView has a layout.

[Sash0k]

Now it fixed. Thank you!

[kurtzmarc]

This appears to be working properly.

[courdi95]

Hello

I still have this problem (centering ot working) with 4.2 version. ....

Has someone a trick to manage that problem ?

[devemux86]

It's fixed in the source at repository, not released yet as new version.
If you play with the 4.2 take a look at the OnGlobalLayoutListener solution.

[courdi95]

I have implemented this solution with addOnGlobalLayoutListener. The trouble now is that the map is centering itself and I can not move it (it comes back) ! How can i remove the listener after the first centering ?

[devemux86]

You can try this:

mapView.getViewTreeObserver().addOnGlobalLayoutListener(new OnGlobalLayoutListener() {
    @Override
    public void onGlobalLayout() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN)
            mapView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
        else
            mapView.getViewTreeObserver().removeGlobalOnLayoutListener(this);
        ...
    }
});

[courdi95]

I finally found how tout manage that.

After centering i added this code in onGlobalLayout :
///////////////
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {

•       mMapView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
  

•   } else {
  

•       mMapView.getViewTreeObserver().removeGlobalOnLayoutListener(this);
  

•   }
  

  ///////////////

This will remove the listener , :-)