-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Burger King in Mattoon, Illinois #4817
Comments
We could do this, but wouldn't it be maybe more correct to just tag that one special Burger King with a Adding the cc @1ec5 , I think he's tagged a few of these before and can let me know if I have it correct? |
I see some ways how it can be handled: (1) document that users of NSI are supposed to take care of (2) complicate system of how NSI applies tags and include info about this exclusion zone (3) have list of false positives within NSI itself (1) relying on |
From the Wikipedia page, the international chain aren't allowed to open a restaurant with the same name within 20km of their competitor, so shouldn't we have a geographic exclude to cover that area? |
That would be (2) from my ideas, but it would be quite a lot effort for a very minor gain. |
(2) is technically possible with an Also, @bhousel has expressed a preference for the simplest include/exclude statements available, which is an argument in favor of (1). My reading of @matkoniecz's comments in Street Complete are not "Hey this one thing is broken" but rather an example of a class of problem that has minimal recourse in SC. Personally, I think the benefit outweighs the detriment, but the point is that he's not as concerned about this specific Burger King as he is about edge cases that may have more instances. |
Yes, I just wanted to point out the worst possible obscure case. And StreetComplete is special here as it will apply NSI silently, without exposing anything to user (so potential misapplying will not be noticed). |
The geographic area associated with an NSI entry isn’t meant to be a strict statement of where a chain is and isn’t. Trademark laws being what they are, there are same-named chains that overlap geographically (“People’s Bank”), but we only need to add so much detail to the geometries in NSI. The Mattoon-based Burger King is already tagged with The Hootses have the right to open another unaffiliated location within that 20-mile-radius area, but they haven’t in the more than half a century since Burger King of Florida, Inc. v. Hoots was decided. If they do, I’m sure the OSM community will find out about it in due time. |
There's an xkcd for that:
I'm not convinced every iD user checks every change every single time, so I don't think SC is entirely unique in that respect (although logos may mean they're not mis-tagging the wrong People's Bank for example.
Given it's pretty trivial to do, is it not worth stopping tagging of BK within Mattoon though, more to trap errors with new BK stores than Hoots based ones? |
I'm sure SC is displaying the logo, and the local community is surely aware of the BK situation on the ground, so I don't expect there to be confusion. I see the exclude rule to primarily be aimed at not clogging up the UI with irrelevant suggestions, not as something authoritative. (In Go Map!! I'm not even looking at excludes, only includes). |
It is not. See streetcomplete/StreetComplete#2290 (comment) streetcomplete/StreetComplete#2290 (comment) |
Ok, well since this issue isn't going away, and we can just do this easily without breaking anything, I changed Burger King's locationSet to: "locationSet": {
"include": ["001"],
"exclude": [[-88.3726, 39.4818]]
}, Location-conflation will create a circle for us that is 25km, not 32km, but maybe I'll add a future enhancement there to let people control the radius of the circle. At least I have an amusing geo story to tell people, and it's pretty great that the locationSets give us so much flexibility. |
Well, this is embarrassing. After some more research I have learned that they aren't in Australia either - there they use the name Hungry Jacks, which we have in the index already. I updated the locationSet appropriately. Sorry Aussies! |
Thanks @bhousel . Sorry I wasn't intending to just throw it over the fence, I was going to try and take a look at them soon. Sort of linked to Hungry Jack's what's the deal with the alternative script ones, should we be excluding the English one from these countries too?:
Personally I'd feel the opposite (within reason, e.g. a 25km circle not 32km), if NSI is trying to be an authoritative source of brands etc, then it should try and be as authoritative as it can about where they're available. Otherwise you could just list everything as being relevant everywhere. |
We don't need exclude the regional brands.. The matcher code will still match "Burger King" in places like Japan, but will return a local result "バーガーキング" ( I wrote a whole bunch of test code last week to make sure that the matcher was performing well and returning results this way, check it out: https://github.com/osmlab/name-suggestion-index/blob/main/tests/matcher.test.js#L133 This was really the last big thing I wanted to finish before an official v5 release - it's important to get this right for iD's validator. |
Update on this! I released an update to location-conflation today to support an optional |
See for example https://www.openstreetmap.org/way/165659335#map=19/39.48195/-88.37310 https://en.wikipedia.org/wiki/Burger_King_(Mattoon,_Illinois)
Burger King has the right to use this name throughout USA, with the exception of a 20-mile radius surrounding a restaurant, also called Burger King, in Mattoon.
Originally posted by @matkoniecz in streetcomplete/StreetComplete#2290 (comment)
The text was updated successfully, but these errors were encountered: