Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten receiver name in apptesting test suite #1280

Closed
AlpinYukseloglu opened this issue Apr 18, 2022 · 2 comments · Fixed by #1374
Closed

Shorten receiver name in apptesting test suite #1280

AlpinYukseloglu opened this issue Apr 18, 2022 · 2 comments · Fixed by #1374
Assignees
@alexanderbez

Comments

@AlpinYukseloglu
Copy link
Contributor

Shorten keeperTestHelper *KeeperTestHelper in app/apptesting/test_suite.go to remove some of the bulk/clutter from the app test suite.

Reference to @alexanderbez's post in #1145 (comment)
@ValarDragon
Copy link
Member

ValarDragon commented Apr 29, 2022 •
edited

Great call! Perhaps we just call it suite?

@alexanderbez
Copy link
Contributor

Yup @ValarDragon

@alexanderbez alexanderbez self-assigned this Apr 29, 2022
@alexanderbez alexanderbez mentioned this issue Apr 29, 2022
Merged
@mergify mergify bot closed this as completed in #1374 Apr 29, 2022
mergify bot pushed a commit that referenced this issue Apr 29, 2022
@alexanderbez
refactor: cleanup test receiver (#1374)
405ea1c 
Cleanup receiver name in app tests

closes: #1280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: cleanup test receiver osmosis-labs/osmosis
3 participants
@alexanderbez @ValarDragon @AlpinYukseloglu