-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for CalcExitPool #1540
add test for CalcExitPool #1540
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
Coverage 19.46% 19.46%
=======================================
Files 241 242 +1
Lines 32183 32255 +72
=======================================
+ Hits 6264 6279 +15
- Misses 24767 24822 +55
- Partials 1152 1154 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this! The tests look great. Had a couple of minor comments, please let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on making the calculations for expected exit coins! Left a few minor comments
Co-authored-by: Roman <roman@osmosis.team>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #1512
What is the purpose of the change
CalcExitPool
.Brief Changelog
CalcExitPool
Logic inx/gamm/pool-models/internal/cfmm_common/lp.go
.CalcExitPool
whenexitingShares
is grater or equal to pool'stotal shares
so that there's noInt64() out of bound
panic.Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no