fix: fix the account number of x/tokenfactory module account
#5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadamu
changed the title
x/tokenfactory module account
dadamu
commented
Jun 16, 2023
| @@ -83,6 +82,5 @@ func (k *Keeper) SetContractKeeper(contractKeeper types.ContractKeeper) { | |||
| // it purely mints and burns them on behalf of the admin of respective denoms, | |||
| // and sends to the relevant address. | |||
| func (k Keeper) CreateModuleAccount(ctx sdk.Context) { | |||
| moduleAcc := authtypes.NewEmptyModuleAccount(types.ModuleName, authtypes.Minter, authtypes.Burner) | |||
| k.accountKeeper.SetModuleAccount(ctx, moduleAcc) | |||
| k.accountKeeper.GetModuleAccount(ctx, types.ModuleName) | |||
There was a problem hiding this comment.
No, it should be created at the genesis phase, see x/gov calls GetModuleAccount to create the module account as follows:
https://github.com/cosmos/cosmos-sdk/blob/release/v0.45.x/x/gov/genesis.go#L19
mattverse
reviewed
Jun 16, 2023
|
let's also add a changelog for this please |
mattverse
added
the
V:state/compatible/no_backport
|
@mattverse Added changelog entry. The last test failing seems not related to this change if I am not wrong, and also test is passed by manually and the latest test checking action. |
|
@mattverse Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes the account number of
x/tokenfactoryis wrongly set by genesis sinceCreateModuleAccountonly stores the module account with default account number 0, and it it also missing an update toglobal_account_numberinsidex/auth.To solve it,
CreateModuleAccountshould callAccountKeeper.GetModuleAccountinstead ofAccountKeeper.SetModuleAccount, or it lost to set account number properly, see:https://github.com/cosmos/cosmos-sdk/blob/main/x/auth/keeper/keeper.go#L252
Testing and Verifying
This change added tests and can be verified as follows:
x/tokenfactorymodule account is correctly setDocumentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)