We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look at this line: https://github.com/OsmSharp/core/blob/develop/src/OsmSharp.Geo/DefaultFeatureInterpreter.cs#L524
private static AttributesTable TagsAndIdToAttributes(ICompleteOsmGeo osmObject) { var attr = osmObject.Tags.ToAttributeTable(); attr.Add("id", osmObject.Id); // Yes, this line return attr; }
The problem is: what if we already have id tag? It will simply throw ArgumentException from here and your data consumption is broken.
id
ArgumentException
My proposal is to check whether AttributeTable already contains id tag, instead of precipitately adding it.
AttributeTable
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Look at this line: https://github.com/OsmSharp/core/blob/develop/src/OsmSharp.Geo/DefaultFeatureInterpreter.cs#L524
The problem is: what if we already have
id
tag? It will simply throwArgumentException
from here and your data consumption is broken.My proposal is to check whether
AttributeTable
already containsid
tag, instead of precipitately adding it.The text was updated successfully, but these errors were encountered: