May be a memory leak in PbfReader ?

[WernerMairl]

Hi

May be there is a memory issue inside the PbfReader!

core/src/OsmSharp/IO/PBF/PBFReader.cs

Lines 114 to 133 in b9a3e5b

	var ms = new MemoryStream(blob.zlib_data);
	sourceStream = new ZLibStreamWrapper(ms);
	}
	// use the stream to read the block.
	using (sourceStream)
	{
	if (header.type == Encoder.OSMHeader)
	{
	_runtimeTypeModel.Deserialize(sourceStream, null, _headerBlockType);
	notFoundBut = true;
	}
	if (header.type == Encoder.OSMData)
	{
	block = _runtimeTypeModel.Deserialize(sourceStream, _block, _primitiveBlockType) as PrimitiveBlock;
	}
	}
	}
	return block;

The MemoryStream in Line 114 seems never be disposed, because the ZLibStreamWrapper seems to not close/dispose the wrapped stream!

OK, may be the GC solves this problem later in time, but (Memory) streams should be disposed asap...

i hope this helps...

br
Werner

[xivk]

Hi, see: https://stackoverflow.com/questions/4195746/memorystream-must-be-explicitely-be-disposed